Subject: Coverity: snd_ctl_disconnect_layer(): Possible Control flow issues

From: coverity-bot <[email-masked]>
Date: Wed, 31 Mar 2021 15:03:54 -0700

Hello!

This is an experimental semi-automated report about issues detected by
Coverity from a scan of next-20210331 as part of the linux-next scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan

You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by commits:

  None
    3f0638a0333b ("ALSA: control - add layer registration routines")

Coverity reported the following:

*** CID 1503580:  Possible Control flow issues  (DEADCODE)
/sound/core/control.c: 2082 in snd_ctl_disconnect_layer()
2076     	down_write(&snd_ctl_layer_rwsem);
2077     	for (lops2 = snd_ctl_layer, prev_lops2 = NULL; lops2; lops2 = lops2->next)
2078     		if (lops2 == lops) {
2079     			if (!prev_lops2)
2080     				snd_ctl_layer = lops->next;
2081     			else
vvv     CID 1503580:  Possible Control flow issues  (DEADCODE)
vvv     Execution cannot reach this statement: "prev_lops2->next = lops->next;".
2082     				prev_lops2->next = lops->next;
2083     			break;
2084     		}
2085     	up_write(&snd_ctl_layer_rwsem);
2086     }
2087     EXPORT_SYMBOL_GPL(snd_ctl_disconnect_layer);

If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):

Reported-by: coverity-bot <[email-masked]>
Addresses-Coverity-ID: 1503580 ("Possible Control flow issues")
Fixes: 3f0638a0333b ("ALSA: control - add layer registration routines")

Thanks for your attention!

-- 
Coverity-bot