Subject: Coverity: venus_isr(): Null pointer dereferences

From: coverity-bot <[email-masked]>
Date: Wed, 7 Apr 2021 12:44:59 -0700

Hello!

This is an experimental semi-automated report about issues detected by
Coverity from a scan of next-20210407 as part of the linux-next scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan

You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by commits:

  Tue Jun 20 08:53:40 2017 -0300
    d96d3f30c0f2 ("[media] media: venus: hfi: add Venus HFI files")

Coverity reported the following:

*** CID 1503707:  Null pointer dereferences  (REVERSE_INULL)
/drivers/media/platform/qcom/venus/hfi_venus.c: 1100 in venus_isr()
1094     {
1095     	struct venus_hfi_device *hdev = to_hfi_priv(core);
1096     	u32 status;
1097     	void __iomem *cpu_cs_base = hdev->core->cpu_cs_base;
1098     	void __iomem *wrapper_base = hdev->core->wrapper_base;
1099
vvv     CID 1503707:  Null pointer dereferences  (REVERSE_INULL)
vvv     Null-checking "hdev" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
1100     	if (!hdev)
1101     		return IRQ_NONE;
1102
1103     	status = readl(wrapper_base + WRAPPER_INTR_STATUS);
1104     	if (IS_V6(core)) {
1105     		if (status & WRAPPER_INTR_STATUS_A2H_MASK ||

If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):

Reported-by: coverity-bot <[email-masked]>
Addresses-Coverity-ID: 1503707 ("Null pointer dereferences")
Fixes: d96d3f30c0f2 ("[media] media: venus: hfi: add Venus HFI files")

Thanks for your attention!

-- 
Coverity-bot