Subject: Coverity: cdns3_gadget_start(): Error handling issues

From: coverity-bot <[email-masked]>
Date: Thu, 8 Apr 2021 17:11:27 -0700

Hello!

This is an experimental semi-automated report about issues detected by
Coverity from a scan of next-20210408 as part of the linux-next scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan

You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by commits:

  Thu Aug 29 10:57:04 2019 +0300
    7733f6c32e36 ("usb: cdns3: Add Cadence USB3 DRD Driver")

Coverity reported the following:

*** CID 1503690:  Error handling issues  (CHECKED_RETURN)
/drivers/usb/cdns3/cdns3-gadget.c: 3143 in cdns3_gadget_start()
3137     			cdns3_gadget_release);
3138     	cdns->gadget_dev = priv_dev;
3139     	priv_dev->sysdev = cdns->dev;
3140     	priv_dev->dev = cdns->dev;
3141     	priv_dev->regs = cdns->dev_regs;
3142
vvv     CID 1503690:  Error handling issues  (CHECKED_RETURN)
vvv     Calling "device_property_read_u16" without checking return value (as is done elsewhere 4 out of 5 times).
3143     	device_property_read_u16(priv_dev->dev, "cdns,on-chip-buff-size",
3144     				 &priv_dev->onchip_buffers);
3145
3146     	if (priv_dev->onchip_buffers <=  0) {
3147     		u32 reg = readl(&priv_dev->regs->usb_cap2);
3148

If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):

Reported-by: coverity-bot <[email-masked]>
Addresses-Coverity-ID: 1503690 ("Error handling issues")
Fixes: 7733f6c32e36 ("usb: cdns3: Add Cadence USB3 DRD Driver")

Thanks for your attention!

-- 
Coverity-bot