From: Vladimir Oltean <olteanv@gmail•com>
To: Randy Dunlap <rdunlap@infradead•org>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
Linux Next Mailing List <linux-next@vger•kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
John Crispin <john@phrozen•org>,
Ansuel Smith <ansuelsmth@gmail•com>, Andrew Lunn <andrew@lunn•ch>,
Vivien Didelot <vivien.didelot@gmail•com>,
Florian Fainelli <f.fainelli@gmail•com>
Subject: Re: linux-next: Tree for May 18 (drivers/net/dsa/qca8k.c)
Date: Tue, 18 May 2021 19:43:48 +0300 [thread overview]
Message-ID: <20210518164348.vbuxaqg4s3mwzp4e@skbuf> (raw)
In-Reply-To: <785e9083-174e-5287-8ad0-1b5b842e2282@infradead.org>
Hi Randy,
On Tue, May 18, 2021 at 09:32:49AM -0700, Randy Dunlap wrote:
> On 5/18/21 2:27 AM, Stephen Rothwell wrote:
> > Hi all,
> >
> > Changes since 20210514:
> >
>
> on x86_64:
> # CONFIG_OF is not set
>
> ../drivers/net/dsa/qca8k.c: In function ‘qca8k_mdio_register’:
> ../drivers/net/dsa/qca8k.c:797:9: error: implicit declaration of function ‘devm_of_mdiobus_register’; did you mean ‘devm_mdiobus_register’? [-Werror=implicit-function-declaration]
> return devm_of_mdiobus_register(priv->dev, bus, mdio);
>
>
> Should there be a stub for this function in <linux/of_mdio.h>?
> or the driver could add a dependency on OF_MDIO.
>
> Full randconfig file is attached.
>
> --
> ~Randy
> Reported-by: Randy Dunlap <rdunlap@infradead•org>
>
Would something like this work?
-----------------------------[ cut here ]-----------------------------
From 36c0b3f04ebfa51e52bd1bc2dc447d12d1c6e119 Mon Sep 17 00:00:00 2001
From: Vladimir Oltean <olteanv@gmail•com>
Date: Tue, 18 May 2021 19:39:18 +0300
Subject: [PATCH] net: mdio: provide shim implementation of
devm_of_mdiobus_register
Similar to the way in which of_mdiobus_register() has a fallback to the
non-DT based mdiobus_register() when CONFIG_OF is not set, we can create
a shim for the device-managed devm_of_mdiobus_register() which calls
devm_mdiobus_register() and discards the struct device_node *.
In particular, this solves a build issue with the qca8k DSA driver which
uses devm_of_mdiobus_register and can be compiled without CONFIG_OF.
Reported-by: Randy Dunlap <rdunlap@infradead•org>
Signed-off-by: Vladimir Oltean <olteanv@gmail•com>
---
include/linux/of_mdio.h | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/include/linux/of_mdio.h b/include/linux/of_mdio.h
index 2b05e7f7c238..da633d34ab86 100644
--- a/include/linux/of_mdio.h
+++ b/include/linux/of_mdio.h
@@ -72,6 +72,13 @@ static inline int of_mdiobus_register(struct mii_bus *mdio, struct device_node *
return mdiobus_register(mdio);
}
+static inline int devm_of_mdiobus_register(struct device *dev,
+ struct mii_bus *mdio,
+ struct device_node *np)
+{
+ return devm_mdiobus_register(dev, mdio);
+}
+
static inline struct mdio_device *of_mdio_find_device(struct device_node *np)
{
return NULL;
-----------------------------[ cut here ]-----------------------------
next prev parent reply other threads:[~2021-05-18 16:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 9:27 linux-next: Tree for May 18 Stephen Rothwell
2021-05-18 16:32 ` linux-next: Tree for May 18 (drivers/net/dsa/qca8k.c) Randy Dunlap
2021-05-18 16:43 ` Vladimir Oltean [this message]
2021-05-18 16:57 ` Randy Dunlap
2021-05-18 17:02 ` Vladimir Oltean
2021-05-18 17:33 ` Andrew Lunn
2021-05-18 18:53 ` John Crispin
2021-05-18 17:02 ` linux-next: Tree for May 18 (kernel/bpf/bpf_lsm.o) Randy Dunlap
2021-05-25 17:30 ` Randy Dunlap
2021-05-25 18:26 ` Daniel Borkmann
2021-05-25 18:31 ` Daniel Borkmann
2021-05-25 19:01 ` Randy Dunlap
2021-05-25 19:15 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210518164348.vbuxaqg4s3mwzp4e@skbuf \
--to=olteanv@gmail$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=ansuelsmth@gmail$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=john@phrozen$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rdunlap@infradead$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=vivien.didelot@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox