From: Mikko Perttunen <mperttunen@nvidia•com>
To: thierry.reding@gmail•com, jonathanh@nvidia•com
Cc: linux-tegra@vger•kernel.org, linux-next@vger•kernel.org,
linux-kernel@vger•kernel.org,
Mikko Perttunen <mperttunen@nvidia•com>,
kernel test robot <lkp@intel•com>,
Stephen Rothwell <sfr@canb•auug.org.au>
Subject: [PATCH] gpu: host1x: Remove unused functions
Date: Tue, 20 Jul 2021 13:42:03 +0300 [thread overview]
Message-ID: <20210720104203.2045449-1-mperttunen@nvidia.com> (raw)
In-Reply-To: <20210720180805.57baa5c7@canb.auug.org.au>
Remove the host1x_fence_create_fd and host1x_fence_extract
functions that are not used anywhere. host1x_fence_create_fd
is additionally using sync_file_create without there being
a Kconfig dependency to SYNC_FILE, causing builds to fail.
Reported-by: kernel test robot <lkp@intel•com>
Reported-by: Stephen Rothwell <sfr@canb•auug.org.au>
Signed-off-by: Mikko Perttunen <mperttunen@nvidia•com>
---
drivers/gpu/host1x/fence.c | 43 --------------------------------------
include/linux/host1x.h | 1 -
2 files changed, 44 deletions(-)
diff --git a/drivers/gpu/host1x/fence.c b/drivers/gpu/host1x/fence.c
index 06c6b86237bd..5de4affcb918 100644
--- a/drivers/gpu/host1x/fence.c
+++ b/drivers/gpu/host1x/fence.c
@@ -164,46 +164,3 @@ struct dma_fence *host1x_fence_create(struct host1x_syncpt *sp, u32 threshold)
return &fence->base;
}
EXPORT_SYMBOL(host1x_fence_create);
-
-int host1x_fence_create_fd(struct host1x_syncpt *sp, u32 threshold)
-{
- struct sync_file *file;
- struct dma_fence *f;
- int fd;
-
- f = host1x_fence_create(sp, threshold);
- if (IS_ERR(f))
- return PTR_ERR(f);
-
- fd = get_unused_fd_flags(O_CLOEXEC);
- if (fd < 0) {
- dma_fence_put(f);
- return fd;
- }
-
- file = sync_file_create(f);
- dma_fence_put(f);
- if (!file)
- return -ENOMEM;
-
- fd_install(fd, file->file);
-
- return fd;
-}
-EXPORT_SYMBOL(host1x_fence_create_fd);
-
-int host1x_fence_extract(struct dma_fence *fence, u32 *id, u32 *threshold)
-{
- struct host1x_syncpt_fence *f;
-
- if (fence->ops != &host1x_syncpt_fence_ops)
- return -EINVAL;
-
- f = container_of(fence, struct host1x_syncpt_fence, base);
-
- *id = f->sp->id;
- *threshold = f->threshold;
-
- return 0;
-}
-EXPORT_SYMBOL(host1x_fence_extract);
diff --git a/include/linux/host1x.h b/include/linux/host1x.h
index 9b6784708f2e..2127762fc63d 100644
--- a/include/linux/host1x.h
+++ b/include/linux/host1x.h
@@ -171,7 +171,6 @@ void host1x_syncpt_release_vblank_reservation(struct host1x_client *client,
u32 syncpt_id);
struct dma_fence *host1x_fence_create(struct host1x_syncpt *sp, u32 threshold);
-int host1x_fence_extract(struct dma_fence *fence, u32 *id, u32 *threshold);
/*
* host1x channel
--
2.30.1
prev parent reply other threads:[~2021-07-20 10:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 8:08 linux-next: build failure after merge of the drm-tegra tree Stephen Rothwell
2021-07-20 10:42 ` Mikko Perttunen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210720104203.2045449-1-mperttunen@nvidia.com \
--to=mperttunen@nvidia$(echo .)com \
--cc=jonathanh@nvidia$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-tegra@vger$(echo .)kernel.org \
--cc=lkp@intel$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=thierry.reding@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox