From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Jie Deng <jie.deng@intel•com>
Cc: Wolfram Sang <wsa@the-dreams•de>,
Conghui Chen <conghui.chen@intel•com>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Linux Next Mailing List <linux-next@vger•kernel.org>
Subject: Re: linux-next: build warning after merge of the i2c tree
Date: Wed, 18 Aug 2021 17:04:18 +1000 [thread overview]
Message-ID: <20210818170418.5e03390b@canb.auug.org.au> (raw)
In-Reply-To: <1d80c5e6-5d5e-1714-78d8-8d2b9c6f8389@intel.com>
[-- Attachment #1: Type: text/plain, Size: 988 bytes --]
Hi Jie,
On Wed, 18 Aug 2021 14:54:12 +0800 Jie Deng <jie.deng@intel•com> wrote:
>
> On 2021/8/18 14:29, Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the i2c tree, today's linux-next build (powerpc
> > allyesconfig) produced this warning:
> >
> > drivers/i2c/busses/i2c-virtio.c: In function 'virtio_i2c_probe':
> > drivers/i2c/busses/i2c-virtio.c:208:17: warning: unused variable 'pdev' [-Wunused-variable]
> > 208 | struct device *pdev = vdev->dev.parent;
> > | ^~~~
> >
> > Introduced by commit
> >
> > 8fb12751ac78 ("i2c: virtio: add a virtio i2c frontend driver")
>
> Why we have this warning ? In commit 8fb12751ac78, the variable 'pdev' was used in line 237.
>
> https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git/commit/?h=i2c/for-next&id=8fb12751ac78d0a4ba3c604496ffc8dcd1bd6c31
>
When CONFIG_ACPI is not set, ACPI_COMPANION{,_SET} do not use their arguments.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-08-18 7:04 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 6:29 linux-next: build warning after merge of the i2c tree Stephen Rothwell
2021-08-18 6:54 ` Jie Deng
2021-08-18 7:04 ` Stephen Rothwell [this message]
2021-08-18 7:13 ` Jie Deng
-- strict thread matches above, loose matches on Subject: below --
2025-01-15 5:31 Stephen Rothwell
2025-01-15 7:32 ` Wolfram Sang
2024-11-28 2:07 Stephen Rothwell
2024-11-28 6:42 ` Wolfram Sang
2019-08-02 3:21 Stephen Rothwell
2019-08-02 6:04 ` Uwe Kleine-König
2019-06-11 0:25 Stephen Rothwell
2019-06-12 8:19 ` Wolfram Sang
2019-06-12 11:02 ` Mauro Carvalho Chehab
2019-06-12 11:09 ` Wolfram Sang
2019-06-12 11:48 ` Mauro Carvalho Chehab
2019-06-12 12:04 ` Wolfram Sang
2019-06-12 12:32 ` Mauro Carvalho Chehab
2019-06-12 13:15 ` Stephen Rothwell
2019-06-12 13:24 ` Wolfram Sang
2017-06-05 1:11 Stephen Rothwell
2017-06-15 1:34 ` Stephen Rothwell
2017-06-15 7:02 ` Wolfram Sang
2017-06-15 8:48 ` Stephen Rothwell
2014-03-06 2:50 Stephen Rothwell
2010-03-28 23:54 Stephen Rothwell
2010-03-29 13:21 ` Jean Delvare
2010-03-29 14:12 ` Stephen Rothwell
2010-02-17 0:38 Stephen Rothwell
2010-02-17 8:34 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210818170418.5e03390b@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=conghui.chen@intel$(echo .)com \
--cc=jie.deng@intel$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=wsa@the-dreams$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox