From: Stephen Rothwell <sfr@rothwell•id.au>
To: Benson Leung <bleung@google•com>,
Guenter Roeck <groeck@chromium•org>,
Enric Balletbo i Serra <enric.balletbo@collabora•com>,
Dmitry Torokhov <dmitry.torokhov@gmail•com>
Cc: Gwendal Grignou <gwendal@chromium•org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Linux Next Mailing List <linux-next@vger•kernel.org>
Subject: Re: linux-next: build warning after merge of the chrome-platform tree
Date: Mon, 30 Aug 2021 17:21:32 +1000 [thread overview]
Message-ID: <20210830172132.4fc0ae7f@elm.ozlabs.ibm.com> (raw)
In-Reply-To: <20210823152134.00d95cb4@canb.auug.org.au>
[-- Attachment #1: Type: text/plain, Size: 8996 bytes --]
Hi all,
On Mon, 23 Aug 2021 15:21:34 +1000 Stephen Rothwell <sfr@canb•auug.org.au> wrote:
>
> After merging the chrome-platform tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> In file included from include/trace/define_trace.h:102,
> from drivers/platform/chrome/cros_ec_trace.h:178,
> from drivers/platform/chrome/cros_ec_trace.c:215:
> drivers/platform/chrome/./cros_ec_trace.h: In function 'trace_raw_output_cros_ec_sensorhub_timestamp':
> drivers/platform/chrome/./cros_ec_trace.h:95:12: warning: format '%lld' expects argument of type 'long long int', but argument 3 has type 'u32' {aka 'unsigned int'} [-Wformat=]
> 95 | TP_printk("ec_ts: %12lld, ec_fifo_ts: %12lld, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/trace/trace_events.h:399:27: note: in definition of macro 'DECLARE_EVENT_CLASS'
> 399 | trace_event_printf(iter, print); \
> | ^~~~~
> include/trace/trace_events.h:80:9: note: in expansion of macro 'PARAMS'
> 80 | PARAMS(print)); \
> | ^~~~~~
> drivers/platform/chrome/./cros_ec_trace.h:74:1: note: in expansion of macro 'TRACE_EVENT'
> 74 | TRACE_EVENT(cros_ec_sensorhub_timestamp,
> | ^~~~~~~~~~~
> drivers/platform/chrome/./cros_ec_trace.h:95:2: note: in expansion of macro 'TP_printk'
> 95 | TP_printk("ec_ts: %12lld, ec_fifo_ts: %12lld, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
> | ^~~~~~~~~
> In file included from include/trace/trace_events.h:433,
> from include/trace/define_trace.h:102,
> from drivers/platform/chrome/cros_ec_trace.h:178,
> from drivers/platform/chrome/cros_ec_trace.c:215:
> drivers/platform/chrome/./cros_ec_trace.h:95:25: note: format string is defined here
> 95 | TP_printk("ec_ts: %12lld, ec_fifo_ts: %12lld, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
> | ~~~~~^
> | |
> | long long int
> | %12d
> In file included from include/trace/define_trace.h:102,
> from drivers/platform/chrome/cros_ec_trace.h:178,
> from drivers/platform/chrome/cros_ec_trace.c:215:
> drivers/platform/chrome/./cros_ec_trace.h:95:12: warning: format '%lld' expects argument of type 'long long int', but argument 4 has type 'u32' {aka 'unsigned int'} [-Wformat=]
> 95 | TP_printk("ec_ts: %12lld, ec_fifo_ts: %12lld, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/trace/trace_events.h:399:27: note: in definition of macro 'DECLARE_EVENT_CLASS'
> 399 | trace_event_printf(iter, print); \
> | ^~~~~
> include/trace/trace_events.h:80:9: note: in expansion of macro 'PARAMS'
> 80 | PARAMS(print)); \
> | ^~~~~~
> drivers/platform/chrome/./cros_ec_trace.h:74:1: note: in expansion of macro 'TRACE_EVENT'
> 74 | TRACE_EVENT(cros_ec_sensorhub_timestamp,
> | ^~~~~~~~~~~
> drivers/platform/chrome/./cros_ec_trace.h:95:2: note: in expansion of macro 'TP_printk'
> 95 | TP_printk("ec_ts: %12lld, ec_fifo_ts: %12lld, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
> | ^~~~~~~~~
> In file included from include/trace/trace_events.h:433,
> from include/trace/define_trace.h:102,
> from drivers/platform/chrome/cros_ec_trace.h:178,
> from drivers/platform/chrome/cros_ec_trace.c:215:
> drivers/platform/chrome/./cros_ec_trace.h:95:45: note: format string is defined here
> 95 | TP_printk("ec_ts: %12lld, ec_fifo_ts: %12lld, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
> | ~~~~~^
> | |
> | long long int
> | %12d
> In file included from include/trace/define_trace.h:102,
> from drivers/platform/chrome/cros_ec_trace.h:178,
> from drivers/platform/chrome/cros_ec_trace.c:215:
> drivers/platform/chrome/./cros_ec_trace.h: In function 'trace_raw_output_cros_ec_sensorhub_data':
> drivers/platform/chrome/./cros_ec_trace.h:125:12: warning: format '%lld' expects argument of type 'long long int', but argument 4 has type 'u32' {aka 'unsigned int'} [-Wformat=]
> 125 | TP_printk("ec_num: %4d, ec_fifo_ts: %12lld, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/trace/trace_events.h:399:27: note: in definition of macro 'DECLARE_EVENT_CLASS'
> 399 | trace_event_printf(iter, print); \
> | ^~~~~
> include/trace/trace_events.h:80:9: note: in expansion of macro 'PARAMS'
> 80 | PARAMS(print)); \
> | ^~~~~~
> drivers/platform/chrome/./cros_ec_trace.h:105:1: note: in expansion of macro 'TRACE_EVENT'
> 105 | TRACE_EVENT(cros_ec_sensorhub_data,
> | ^~~~~~~~~~~
> drivers/platform/chrome/./cros_ec_trace.h:125:2: note: in expansion of macro 'TP_printk'
> 125 | TP_printk("ec_num: %4d, ec_fifo_ts: %12lld, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
> | ^~~~~~~~~
> In file included from include/trace/trace_events.h:433,
> from include/trace/define_trace.h:102,
> from drivers/platform/chrome/cros_ec_trace.h:178,
> from drivers/platform/chrome/cros_ec_trace.c:215:
> drivers/platform/chrome/./cros_ec_trace.h:125:43: note: format string is defined here
> 125 | TP_printk("ec_num: %4d, ec_fifo_ts: %12lld, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
> | ~~~~~^
> | |
> | long long int
> | %12d
> In file included from include/trace/define_trace.h:102,
> from drivers/platform/chrome/cros_ec_trace.h:178,
> from drivers/platform/chrome/cros_ec_trace.c:215:
> drivers/platform/chrome/./cros_ec_trace.h: In function 'trace_raw_output_cros_ec_sensorhub_filter':
> drivers/platform/chrome/./cros_ec_trace.h:156:12: warning: format '%d' expects argument of type 'int', but argument 7 has type 's64' {aka 'long long int'} [-Wformat=]
> 156 | TP_printk("dx: %12lld. dy: %12lld median_m: %12lld median_error: %12lld len: %d x: %12lld y: %12lld",
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/trace/trace_events.h:399:27: note: in definition of macro 'DECLARE_EVENT_CLASS'
> 399 | trace_event_printf(iter, print); \
> | ^~~~~
> include/trace/trace_events.h:80:9: note: in expansion of macro 'PARAMS'
> 80 | PARAMS(print)); \
> | ^~~~~~
> drivers/platform/chrome/./cros_ec_trace.h:135:1: note: in expansion of macro 'TRACE_EVENT'
> 135 | TRACE_EVENT(cros_ec_sensorhub_filter,
> | ^~~~~~~~~~~
> drivers/platform/chrome/./cros_ec_trace.h:156:2: note: in expansion of macro 'TP_printk'
> 156 | TP_printk("dx: %12lld. dy: %12lld median_m: %12lld median_error: %12lld len: %d x: %12lld y: %12lld",
> | ^~~~~~~~~
> In file included from include/trace/trace_events.h:433,
> from include/trace/define_trace.h:102,
> from drivers/platform/chrome/cros_ec_trace.h:178,
> from drivers/platform/chrome/cros_ec_trace.c:215:
> drivers/platform/chrome/./cros_ec_trace.h:156:80: note: format string is defined here
> 156 | TP_printk("dx: %12lld. dy: %12lld median_m: %12lld median_error: %12lld len: %d x: %12lld y: %12lld",
> | ~^
> | |
> | int
> | %lld
>
> Introduced by commit
>
> d453ceb6549a ("platform/chrome: sensorhub: Add trace events for sample")
I am still seeing these warnings.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-08-30 7:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 5:21 linux-next: build warning after merge of the chrome-platform tree Stephen Rothwell
2021-08-30 7:21 ` Stephen Rothwell [this message]
2021-08-31 0:17 ` Benson Leung
2021-08-31 0:32 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2024-06-03 3:25 Stephen Rothwell
2024-06-03 4:20 ` Tzung-Bi Shih
2022-05-16 11:38 Stephen Rothwell
2022-05-17 13:09 ` Muhammad Usama Anjum
2022-05-18 3:23 ` Bagas Sanjaya
2022-05-18 3:39 ` Tzung-Bi Shih
2022-05-18 4:24 ` Muhammad Usama Anjum
2019-04-16 4:30 Stephen Rothwell
2019-04-16 9:09 ` Enric Balletbo i Serra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210830172132.4fc0ae7f@elm.ozlabs.ibm.com \
--to=sfr@rothwell$(echo .)id.au \
--cc=bleung@google$(echo .)com \
--cc=dmitry.torokhov@gmail$(echo .)com \
--cc=enric.balletbo@collabora$(echo .)com \
--cc=groeck@chromium$(echo .)org \
--cc=gwendal@chromium$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox