From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Alex Deucher <alexdeucher@gmail•com>, Dave Airlie <airlied@linux•ie>
Cc: DRI <dri-devel@lists•freedesktop.org>,
"Alex Deucher" <alexander.deucher@amd•com>,
"Christian König" <christian.koenig@amd•com>,
"Linux Kernel Mailing List" <linux-kernel@vger•kernel.org>,
"Linux Next Mailing List" <linux-next@vger•kernel.org>,
"Philip Yang" <Philip.Yang@amd•com>
Subject: linux-next: manual merge of the amdgpu tree with the drm tree
Date: Fri, 29 Apr 2022 11:03:29 +1000 [thread overview]
Message-ID: <20220429110329.79f6b628@canb.auug.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 1621 bytes --]
Hi all,
Today's linux-next merge of the amdgpu tree got a conflict in:
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
between commit:
047a1b877ed4 ("dma-buf & drm/amdgpu: remove dma_resv workaround")
from the drm tree and commit:
3da2c38231a4 ("drm/amdgpu: Free user pages if amdgpu_cs_parser_bos failed")
from the amdgpu tree.
I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging. You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.
--
Cheers,
Stephen Rothwell
diff --cc drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
index 01853431249d,67bd506fa141..000000000000
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
@@@ -636,9 -642,26 +636,21 @@@ static int amdgpu_cs_parser_bos(struct
}
error_validate:
- if (r) {
- amdgpu_bo_list_for_each_entry(e, p->bo_list) {
- dma_fence_chain_free(e->chain);
- e->chain = NULL;
- }
+ if (r)
ttm_eu_backoff_reservation(&p->ticket, &p->validated);
- out:
- }
+
+ out_free_user_pages:
+ if (r) {
+ amdgpu_bo_list_for_each_userptr_entry(e, p->bo_list) {
+ struct amdgpu_bo *bo = ttm_to_amdgpu_bo(e->tv.bo);
+
+ if (!e->user_pages)
+ continue;
+ amdgpu_ttm_tt_get_user_pages_done(bo->tbo.ttm);
+ kvfree(e->user_pages);
+ e->user_pages = NULL;
+ }
+ }
return r;
}
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next reply other threads:[~2022-04-29 1:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 1:03 Stephen Rothwell [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-02-20 1:28 linux-next: manual merge of the amdgpu tree with the drm tree Stephen Rothwell
2024-11-05 1:28 Stephen Rothwell
2023-07-26 1:10 Stephen Rothwell
2022-11-22 1:28 Stephen Rothwell
2022-10-27 23:57 Stephen Rothwell
2021-10-28 3:06 Stephen Rothwell
2021-10-28 3:22 ` Alex Deucher
2020-11-17 0:31 Stephen Rothwell
2020-11-16 2:03 Stephen Rothwell
2020-04-23 2:13 Stephen Rothwell
2020-02-28 0:21 Stephen Rothwell
2020-02-23 23:38 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220429110329.79f6b628@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=Philip.Yang@amd$(echo .)com \
--cc=airlied@linux$(echo .)ie \
--cc=alexander.deucher@amd$(echo .)com \
--cc=alexdeucher@gmail$(echo .)com \
--cc=christian.koenig@amd$(echo .)com \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox