From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Rob Clark <robdclark@gmail•com>
Cc: Dave Airlie <airlied@linux•ie>,
Linux Next Mailing List <linux-next@vger•kernel.org>,
Haowen Bai <baihaowen@meizu•com>,
Abhinav Kumar <quic_abhinavk@quicinc•com>,
DRI <dri-devel@lists•freedesktop.org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Rob Clark <robdclark@chromium•org>
Subject: Re: linux-next: Fixes tag needs some work in the drm tree
Date: Sat, 4 Jun 2022 10:37:57 +1000 [thread overview]
Message-ID: <20220604103757.29d0b048@canb.auug.org.au> (raw)
In-Reply-To: <CAF6AEGtYS1LYowjf-OiN-C1+4JFTWwOOpP__4iDLo-dFy0t0Tg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1061 bytes --]
Hi Rob,
On Fri, 3 Jun 2022 07:58:14 -0700 Rob Clark <robdclark@gmail•com> wrote:
>
> will the truncated subject confuse the scripts that look for patches
> to backport to stable, ie. do we *really* have to rewrite history to
> fix this?
I don't know what scripts are being used and what they expect, but our
documentation says (Documentation/process/submitting-patches.rst):
If your patch fixes a bug in a specific commit, e.g. you found an issue using
``git bisect``, please use the 'Fixes:' tag with the first 12 characters of
the SHA-1 ID, and the one line summary. Do not split the tag across multiple
lines, tags are exempt from the "wrap at 75 columns" rule in order to simplify
parsing scripts.
But, that being said, doing the rewrite is up to the maintainer. You
could just look at this as a learning experience and do better in the
future.
BTW, my script reacted to the missing closing quotes and parentheses,
which is more like to confuse any scripts that the actual truncation.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-06-04 0:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-03 5:16 linux-next: Fixes tag needs some work in the drm tree Stephen Rothwell
2022-06-03 14:58 ` Rob Clark
2022-06-04 0:37 ` Stephen Rothwell [this message]
2022-06-04 1:12 ` Rob Clark
-- strict thread matches above, loose matches on Subject: below --
2022-09-11 22:54 Stephen Rothwell
2022-07-12 11:27 Stephen Rothwell
2019-10-27 20:23 Stephen Rothwell
2019-10-28 4:09 ` S, Shirish
2019-07-19 8:41 Stephen Rothwell
2019-03-04 8:09 Stephen Rothwell
2019-02-04 5:50 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220604103757.29d0b048@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=airlied@linux$(echo .)ie \
--cc=baihaowen@meizu$(echo .)com \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=quic_abhinavk@quicinc$(echo .)com \
--cc=robdclark@chromium$(echo .)org \
--cc=robdclark@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox