From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Alexei Starovoitov <alexei.starovoitov@gmail•com>
Cc: Vlastimil Babka <vbabka@suse•cz>,
Daniel Borkmann <daniel@iogearbox•net>,
Alexei Starovoitov <ast@kernel•org>,
Andrii Nakryiko <andrii@kernel•org>, bpf <bpf@vger•kernel.org>,
Networking <netdev@vger•kernel.org>,
Hyeonggon Yoo <42.hyeyoo@gmail•com>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Linux Next Mailing List <linux-next@vger•kernel.org>,
Marco Elver <elver@google•com>
Subject: Re: linux-next: build failure after merge of the slab tree
Date: Wed, 7 Sep 2022 17:45:35 +1000 [thread overview]
Message-ID: <20220907174535.4852e7da@canb.auug.org.au> (raw)
In-Reply-To: <CAADnVQKJORAcV75CHE1yG6_+c8qnoOj6gf=zJG9vnWwR5+4SqQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1663 bytes --]
Hi all,
On Tue, 6 Sep 2022 20:05:44 -0700 Alexei Starovoitov <alexei.starovoitov@gmail•com> wrote:
>
> On Tue, Sep 6, 2022 at 11:37 AM Alexei Starovoitov
> <alexei.starovoitov@gmail•com> wrote:
> >
> > On Tue, Sep 6, 2022 at 12:53 AM Vlastimil Babka <vbabka@suse•cz> wrote:
> > >
> > > On 9/6/22 08:51, Stephen Rothwell wrote:
> > > > Hi all,
> > >
> > > Hi,
> > >
> > > > After merging the slab tree, today's linux-next build (powerpc
> > > > ppc64_defconfig) failed like this:
> > > >
> > > > kernel/bpf/memalloc.c: In function 'bpf_mem_free':
> > > > kernel/bpf/memalloc.c:613:33: error: implicit declaration of function '__ksize'; did you mean 'ksize'? [-Werror=implicit-function-declaration]
> > > > 613 | idx = bpf_mem_cache_idx(__ksize(ptr - LLIST_NODE_SZ));
> > > > | ^~~~~~~
> > > > | ksize
> > >
> > > Could you use ksize() here? I'm guessing you picked __ksize() because
> > > kasan_unpoison_element() in mm/mempool.c did, but that's to avoid
> > > kasan_unpoison_range() in ksize() as this caller does it differently.
> > > AFAICS your function doesn't handle kasan differently, so ksize() should
> > > be fine.
> >
> > Ok. Will change to use ksize().
>
> Just pushed the following commit to address the issue:
> https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git/commit/?id=1e660f7ebe0ff6ac65ee0000280392d878630a67
>
> It will get to net-next soon.
I replaced my revert with that patch for today (and will discard that
when it arrives via some other tree).
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-09-07 7:45 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 6:51 linux-next: build failure after merge of the slab tree Stephen Rothwell
2022-09-06 7:53 ` Vlastimil Babka
2022-09-06 18:37 ` Alexei Starovoitov
2022-09-07 3:05 ` Alexei Starovoitov
2022-09-07 6:40 ` Vlastimil Babka
2022-09-07 7:45 ` Stephen Rothwell [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-05-01 5:28 Stephen Rothwell
2024-05-01 15:31 ` Vlastimil Babka
2022-11-25 1:49 Stephen Rothwell
2022-11-25 7:50 ` Vlastimil Babka
2022-11-24 4:39 Stephen Rothwell
2022-11-24 8:56 ` Vlastimil Babka
2013-07-10 2:56 Stephen Rothwell
2013-07-10 7:00 ` Pekka Enberg
2013-07-10 18:48 ` Christoph Lameter
2013-07-11 6:42 ` Pekka Enberg
2011-01-31 3:42 Stephen Rothwell
2011-01-31 19:32 ` Pekka Enberg
2011-02-03 15:19 ` Christoph Lameter
2011-02-08 15:53 ` Christoph Lameter
2011-02-08 15:55 ` Christoph Lameter
2011-02-08 16:50 ` Ted Ts'o
2011-02-08 17:11 ` Sedat Dilek
2011-02-08 17:44 ` Christoph Lameter
2010-12-09 3:03 Stephen Rothwell
2010-12-09 16:25 ` Pekka Enberg
2010-10-27 0:33 Stephen Rothwell
2010-10-27 7:29 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220907174535.4852e7da@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=42.hyeyoo@gmail$(echo .)com \
--cc=alexei.starovoitov@gmail$(echo .)com \
--cc=andrii@kernel$(echo .)org \
--cc=ast@kernel$(echo .)org \
--cc=bpf@vger$(echo .)kernel.org \
--cc=daniel@iogearbox$(echo .)net \
--cc=elver@google$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vbabka@suse$(echo .)cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox