From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Andy Shevchenko <andriy.shevchenko@linux•intel.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Linux Next Mailing List <linux-next@vger•kernel.org>
Subject: Re: linux-next: build failure after merge of the pinctrl-intel tree
Date: Tue, 18 Oct 2022 13:20:08 +1100 [thread overview]
Message-ID: <20221018131942.487808a5@oak.ozlabs.ibm.com> (raw)
In-Reply-To: <20221018131330.75fc1807@canb.auug.org.au>
[-- Attachment #1: Type: text/plain, Size: 3552 bytes --]
Hi all,
On Tue, 18 Oct 2022 13:13:30 +1100 Stephen Rothwell <sfr@canb•auug.org.au> wrote:
>
> After merging the pinctrl-intel tree, today's linux-next build (arm64
> defconfig) failed like this:
drivers/pinctrl/pinctrl-zynqmp.c:483:21: error: variable 'zynqmp_pinconf_ops' has initializer but incomplete type
483 | static const struct pinconf_ops zynqmp_pinconf_ops = {
| ^~~~~~~~~~~
drivers/pinctrl/pinctrl-zynqmp.c:484:10: error: 'const struct pinconf_ops' has no member named 'is_generic'
484 | .is_generic = true,
| ^~~~~~~~~~
drivers/pinctrl/pinctrl-zynqmp.c:484:23: warning: excess elements in struct initializer
484 | .is_generic = true,
| ^~~~
drivers/pinctrl/pinctrl-zynqmp.c:484:23: note: (near initialization for 'zynqmp_pinconf_ops')
drivers/pinctrl/pinctrl-zynqmp.c:485:10: error: 'const struct pinconf_ops' has no member named 'pin_config_get'
485 | .pin_config_get = zynqmp_pinconf_cfg_get,
| ^~~~~~~~~~~~~~
drivers/pinctrl/pinctrl-zynqmp.c:485:27: warning: excess elements in struct initializer
485 | .pin_config_get = zynqmp_pinconf_cfg_get,
| ^~~~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/pinctrl-zynqmp.c:485:27: note: (near initialization for 'zynqmp_pinconf_ops')
drivers/pinctrl/pinctrl-zynqmp.c:486:10: error: 'const struct pinconf_ops' has no member named 'pin_config_set'
486 | .pin_config_set = zynqmp_pinconf_cfg_set,
| ^~~~~~~~~~~~~~
drivers/pinctrl/pinctrl-zynqmp.c:486:27: warning: excess elements in struct initializer
486 | .pin_config_set = zynqmp_pinconf_cfg_set,
| ^~~~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/pinctrl-zynqmp.c:486:27: note: (near initialization for 'zynqmp_pinconf_ops')
drivers/pinctrl/pinctrl-zynqmp.c:487:10: error: 'const struct pinconf_ops' has no member named 'pin_config_group_set'
487 | .pin_config_group_set = zynqmp_pinconf_group_set,
| ^~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/pinctrl-zynqmp.c:487:33: warning: excess elements in struct initializer
487 | .pin_config_group_set = zynqmp_pinconf_group_set,
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/pinctrl-zynqmp.c:487:33: note: (near initialization for 'zynqmp_pinconf_ops')
drivers/pinctrl/pinctrl-zynqmp.c:483:33: error: storage size of 'zynqmp_pinconf_ops' isn't known
483 | static const struct pinconf_ops zynqmp_pinconf_ops = {
| ^~~~~~~~~~~~~~~~~~
> Presumably caused by commit
>
> e6b665a1c9ae ("pinctrl: Clean up headers")
>
> I have applied the following patch for today.
>
> From: Stephen Rothwell <sfr@canb•auug.org.au>
> Date: Tue, 18 Oct 2022 13:06:39 +1100
> Subject: [PATCH] fix up for "pinctrl: Clean up headers"
>
> Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
> ---
> drivers/pinctrl/pinctrl-zynqmp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pinctrl/pinctrl-zynqmp.c b/drivers/pinctrl/pinctrl-zynqmp.c
> index 1a94db1ffa4f..f2be341f73e1 100644
> --- a/drivers/pinctrl/pinctrl-zynqmp.c
> +++ b/drivers/pinctrl/pinctrl-zynqmp.c
> @@ -18,6 +18,7 @@
> #include <linux/firmware/xlnx-zynqmp.h>
>
> #include <linux/pinctrl/pinconf-generic.h>
> +#include <linux/pinctrl/pinconf.h>
> #include <linux/pinctrl/pinctrl.h>
> #include <linux/pinctrl/pinmux.h>
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-10-18 2:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 2:13 linux-next: build failure after merge of the pinctrl-intel tree Stephen Rothwell
2022-10-18 2:20 ` Stephen Rothwell [this message]
2022-10-18 12:29 ` Andy Shevchenko
-- strict thread matches above, loose matches on Subject: below --
2026-05-07 10:47 Thierry Reding
2026-05-07 12:15 ` Thierry Reding
2026-05-11 6:09 ` Manikandan.M
2020-08-20 1:30 Stephen Rothwell
2020-08-20 9:40 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221018131942.487808a5@oak.ozlabs.ibm.com \
--to=sfr@canb$(echo .)auug.org.au \
--cc=andriy.shevchenko@linux$(echo .)intel.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox