public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed

From: coverity-bot <keescook@chromium•org>
To: Harish Kasiviswanathan <Harish.Kasiviswanathan@amd•com>
Cc: "Alex Deucher" <alexander.deucher@amd•com>,
	"Christian König" <christian.koenig@amd•com>,
	"David Airlie" <airlied@gmail•com>,
	amd-gfx@lists•freedesktop.org,
	"Oded Gabbay" <oded.gabbay@gmail•com>,
	"Jay Cornwall" <Jay.Cornwall@amd•com>,
	"Ben Goz" <ben.goz@amd•com>,
	dri-devel@lists•freedesktop.org, linux-kernel@vger•kernel.org,
	"Kent Russell" <kent.russell@amd•com>,
	"Felix Kuehling" <Felix.Kuehling@amd•com>,
	"Pan, Xinhui" <Xinhui.Pan@amd•com>,
	"Daniel Vetter" <daniel@ffwll•ch>,
	"Amber Lin" <Amber.Lin@amd•com>,
	"Gustavo A. R. Silva" <gustavo@embeddedor•com>,
	linux-next@vger•kernel.org, linux-hardening@vger•kernel.org
Subject: Coverity: kfd_parse_subtype_cache(): Memory - corruptions
Date: Fri, 4 Nov 2022 12:41:01 -0700	[thread overview]
Message-ID: <202211041239.2B98F280@keescook> (raw)

Hello!

This is an experimental semi-automated report about issues detected by
Coverity from a scan of next-20221104 as part of the linux-next scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan

You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by commits:

  Fri Dec 8 23:08:59 2017 -0500
    3a87177eb141 ("drm/amdkfd: Add topology support for dGPUs")

Coverity reported the following:

*** CID 1527133:  Memory - corruptions  (OVERRUN)
drivers/gpu/drm/amd/amdkfd/kfd_crat.c:1113 in kfd_parse_subtype_cache()
1107     			props->cache_size = cache->cache_size;
1108     			props->cacheline_size = cache->cache_line_size;
1109     			props->cachelines_per_tag = cache->lines_per_tag;
1110     			props->cache_assoc = cache->associativity;
1111     			props->cache_latency = cache->cache_latency;
1112
vvv     CID 1527133:  Memory - corruptions  (OVERRUN)
vvv     Overrunning array "cache->sibling_map" of 32 bytes by passing it to a function which accesses it at byte offset 63 using argument "64UL". [Note: The source code implementation of the function has been overridden by a builtin model.]
1113     			memcpy(props->sibling_map, cache->sibling_map,
1114     					sizeof(props->sibling_map));
1115
1116     			/* set the sibling_map_size as 32 for CRAT from ACPI */
1117     			props->sibling_map_size = CRAT_SIBLINGMAP_SIZE;
1118

If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):

Reported-by: coverity-bot <keescook+coverity-bot@chromium•org>
Addresses-Coverity-ID: 1527133 ("Memory - corruptions")
Fixes: 3a87177eb141 ("drm/amdkfd: Add topology support for dGPUs")

I'm not sure why this suddenly appeared after 5 years, but the read
over-run looks legit:

struct crat_subtype_cache {
        ...
        uint8_t         sibling_map[CRAT_SIBLINGMAP_SIZE];

#define CRAT_SIBLINGMAP_SIZE    32


struct kfd_cache_properties {
        ...
        uint8_t                 sibling_map[CACHE_SIBLINGMAP_SIZE];

#define CACHE_SIBLINGMAP_SIZE 64

Thanks for your attention!

-- 
Coverity-bot

next             reply	other threads:[~2022-11-04 19:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-04 19:41 coverity-bot [this message]
2022-11-04 20:40 ` Coverity: kfd_parse_subtype_cache(): Memory - corruptions Felix Kuehling
2022-11-07  6:41   ` Ma, Jun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202211041239.2B98F280@keescook \
    --to=keescook@chromium$(echo .)org \
    --cc=Amber.Lin@amd$(echo .)com \
    --cc=Felix.Kuehling@amd$(echo .)com \
    --cc=Harish.Kasiviswanathan@amd$(echo .)com \
    --cc=Jay.Cornwall@amd$(echo .)com \
    --cc=Xinhui.Pan@amd$(echo .)com \
    --cc=airlied@gmail$(echo .)com \
    --cc=alexander.deucher@amd$(echo .)com \
    --cc=amd-gfx@lists$(echo .)freedesktop.org \
    --cc=ben.goz@amd$(echo .)com \
    --cc=christian.koenig@amd$(echo .)com \
    --cc=daniel@ffwll$(echo .)ch \
    --cc=dri-devel@lists$(echo .)freedesktop.org \
    --cc=gustavo@embeddedor$(echo .)com \
    --cc=kent.russell@amd$(echo .)com \
    --cc=linux-hardening@vger$(echo .)kernel.org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=oded.gabbay@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox