From: coverity-bot <keescook@chromium•org>
To: Lyude Paul <lyude@redhat•com>
Cc: Thomas Zimmermann <tzimmermann@suse•de>,
linux-kernel@vger•kernel.org, Ilia Mirkin <imirkin@alum•mit.edu>,
Daniel Vetter <daniel@ffwll•ch>,
Karol Herbst <kherbst@redhat•com>,
Ben Skeggs <bskeggs@redhat•com>, David Airlie <airlied@gmail•com>,
"Nathan E. Egge" <unlord@xiph•org>,
dri-devel@lists•freedesktop.org, nouveau@lists•freedesktop.org,
Jani Nikula <jani.nikula@intel•com>,
Dave Airlie <airlied@redhat•com>,
"Gustavo A. R. Silva" <gustavo@embeddedor•com>,
linux-next@vger•kernel.org, linux-hardening@vger•kernel.org
Subject: Coverity: nouveau_dp_irq(): Null pointer dereferences
Date: Thu, 10 Nov 2022 08:50:04 -0800 [thread overview]
Message-ID: <202211100850.7A8DD75@keescook> (raw)
Hello!
This is an experimental semi-automated report about issues detected by
Coverity from a scan of next-20221110 as part of the linux-next scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by commits:
Mon Aug 31 19:10:08 2020 -0400
a0922278f83e ("drm/nouveau/kms/nv50-: Refactor and cleanup DP HPD handling")
Coverity reported the following:
*** CID 1527266: Null pointer dereferences (REVERSE_INULL)
drivers/gpu/drm/nouveau/nouveau_dp.c:237 in nouveau_dp_irq()
231 struct nouveau_encoder *outp = find_encoder(connector, DCB_OUTPUT_DP);
232 struct nouveau_drm *drm = nouveau_drm(outp->base.base.dev);
233 struct nv50_mstm *mstm;
234 u64 hpd = 0;
235 int ret;
236
vvv CID 1527266: Null pointer dereferences (REVERSE_INULL)
vvv Null-checking "outp" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
237 if (!outp)
238 return;
239
240 mstm = outp->dp.mstm;
241 NV_DEBUG(drm, "service %s\n", connector->name);
242
If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):
Reported-by: coverity-bot <keescook+coverity-bot@chromium•org>
Addresses-Coverity-ID: 1527266 ("Null pointer dereferences")
Fixes: a0922278f83e ("drm/nouveau/kms/nv50-: Refactor and cleanup DP HPD handling")
Thanks for your attention!
--
Coverity-bot
next reply other threads:[~2022-11-10 16:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 16:50 coverity-bot [this message]
2022-11-11 9:13 ` Coverity: nouveau_dp_irq(): Null pointer dereferences Jani Nikula
2022-11-11 19:21 ` Kees Cook
2022-11-11 20:06 ` Karol Herbst
2022-11-11 20:16 ` Kees Cook
2022-11-11 20:38 ` Karol Herbst
2022-11-14 10:07 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202211100850.7A8DD75@keescook \
--to=keescook@chromium$(echo .)org \
--cc=airlied@gmail$(echo .)com \
--cc=airlied@redhat$(echo .)com \
--cc=bskeggs@redhat$(echo .)com \
--cc=daniel@ffwll$(echo .)ch \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=gustavo@embeddedor$(echo .)com \
--cc=imirkin@alum$(echo .)mit.edu \
--cc=jani.nikula@intel$(echo .)com \
--cc=kherbst@redhat$(echo .)com \
--cc=linux-hardening@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=lyude@redhat$(echo .)com \
--cc=nouveau@lists$(echo .)freedesktop.org \
--cc=tzimmermann@suse$(echo .)de \
--cc=unlord@xiph$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox