From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Luis Chamberlain <mcgrof@kernel•org>, David Miller <davem@davemloft•net>
Cc: Networking <netdev@vger•kernel.org>,
Alexei Starovoitov <ast@kernel•org>, Jiri Olsa <jolsa@kernel•org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Linux Next Mailing List <linux-next@vger•kernel.org>,
Zhen Lei <thunder.leizhen@huawei•com>
Subject: linux-next: manual merge of the modules tree with the net-next tree
Date: Mon, 14 Nov 2022 10:46:33 +1100 [thread overview]
Message-ID: <20221114104633.4961d175@canb.auug.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 2371 bytes --]
Hi all,
Today's linux-next merge of the modules tree got conflicts in:
include/linux/module.h
kernel/module/kallsyms.c
between commit:
73feb8d5fa3b ("kallsyms: Make module_kallsyms_on_each_symbol generally available")
from the net-next tree and commit:
90de88426f3c ("livepatch: Improve the search performance of module_kallsyms_on_each_symbol()")
from the modules tree.
I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging. You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.
--
Cheers,
Stephen Rothwell
diff --cc include/linux/module.h
index 35876e89eb93,3b312a1fcf59..000000000000
--- a/include/linux/module.h
+++ b/include/linux/module.h
@@@ -879,17 -878,8 +878,17 @@@ static inline bool module_sig_ok(struc
}
#endif /* CONFIG_MODULE_SIG */
+#if defined(CONFIG_MODULES) && defined(CONFIG_KALLSYMS)
- int module_kallsyms_on_each_symbol(int (*fn)(void *, const char *,
- struct module *, unsigned long),
+ int module_kallsyms_on_each_symbol(const char *modname,
+ int (*fn)(void *, const char *, unsigned long),
void *data);
+#else
- static inline int module_kallsyms_on_each_symbol(int (*fn)(void *, const char *,
- struct module *, unsigned long),
- void *data)
++static inline int module_kallsyms_on_each_symbol(const char *modname,
++ int (*fn)(void *, const char *, unsigned long),
++ void *data);
+{
+ return -EOPNOTSUPP;
+}
+#endif /* CONFIG_MODULES && CONFIG_KALLSYMS */
#endif /* _LINUX_MODULE_H */
diff --cc kernel/module/kallsyms.c
index 4523f99b0358,329cef573675..000000000000
--- a/kernel/module/kallsyms.c
+++ b/kernel/module/kallsyms.c
@@@ -494,8 -494,9 +494,8 @@@ unsigned long module_kallsyms_lookup_na
return ret;
}
- int module_kallsyms_on_each_symbol(int (*fn)(void *, const char *,
- struct module *, unsigned long),
-#ifdef CONFIG_LIVEPATCH
+ int module_kallsyms_on_each_symbol(const char *modname,
+ int (*fn)(void *, const char *, unsigned long),
void *data)
{
struct module *mod;
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next reply other threads:[~2022-11-13 23:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-13 23:46 Stephen Rothwell [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-11-13 23:52 linux-next: manual merge of the modules tree with the net-next tree Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221114104633.4961d175@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=ast@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=jolsa@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mcgrof@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=thunder.leizhen@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox