Subject: Re: linux-next: manual merge of the drm-misc tree with the origin tree

From: Stephen Rothwell <[email-masked]>
Date: Fri, 18 Nov 2022 09:06:36 +1100

Hi Nathan,

On Thu, 17 Nov 2022 10:29:33 -0700 Nathan Chancellor <[email-masked]> wrote:
>
> This resolution is not quite right, as pointed out by clang:
> 
>     drivers/gpu/drm/vc4/vc4_hdmi.c:351:14: error: variable 'vc4_hdmi' is uninitialized when used here [-Werror,-Wuninitialized]
>             mutex_lock(&vc4_hdmi->mutex);
>                         ^~~~~~~~
>     ./include/linux/mutex.h:187:44: note: expanded from macro 'mutex_lock'
>     #define mutex_lock(lock) mutex_lock_nested(lock, 0)
>                                                ^~~~
>     drivers/gpu/drm/vc4/vc4_hdmi.c:322:27: note: initialize the variable 'vc4_hdmi' to silence this warning
>             struct vc4_hdmi *vc4_hdmi;
>                                      ^
>                                       = NULL
>     1 error generated.
> 
> Obviously, the assignment of vc4_hdmi should be before mutex_lock().

Thanks for pointing that out (silly me :-) ).  I have fixed up the
resolution for today.

-- 
Cheers,
Stephen Rothwell