From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Mark Brown <broonie@kernel•org>
Cc: Paolo Bonzini <pbonzini@redhat•com>,
Shuah Khan <shuah@kernel•org>, Marc Zyngier <maz@kernel•org>,
kvmarm@lists•linux.dev, kvm@vger•kernel.org,
linux-next@vger•kernel.org, linux-kselftest@vger•kernel.org,
Sean Christopherson <seanjc@google•com>,
Ricardo Koller <ricarkol@google•com>
Subject: Re: [PATCH] KVM: selftests: Fix build due to ucall_uninit() removal
Date: Wed, 7 Dec 2022 07:49:04 +1100 [thread overview]
Message-ID: <20221207074904.2f9d04ed@canb.auug.org.au> (raw)
In-Reply-To: <20221206181506.252537-1-broonie@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 2074 bytes --]
Hi Mark,
On Tue, 6 Dec 2022 18:15:06 +0000 Mark Brown <broonie@kernel•org> wrote:
>
> Today's -next fails to build on arm64 due to:
>
> In file included from include/kvm_util.h:11,
> from aarch64/page_fault_test.c:15:
> include/ucall_common.h:36:47: note: expected ‘vm_paddr_t’ {aka ‘long unsigned int’} but argument is of type ‘void *’
> 36 | void ucall_init(struct kvm_vm *vm, vm_paddr_t mmio_gpa);
> | ~~~~~~~~~~~^~~~~~~~
> aarch64/page_fault_test.c:725:2: warning: implicit declaration of function ‘ucall_uninit’; did you mean ‘ucall_init’? [-Wimplicit-function-declaration]
> 725 | ucall_uninit(vm);
> | ^~~~~~~~~~~~
> | ucall_init
>
> which is caused by commit
>
> interacting poorly with commit
>
> 28a65567acb5 ("KVM: selftests: Drop now-unnecessary ucall_uninit()")
>
> As is done for other ucall_uninit() users remove the call in the newly added
> page_fault_test.c.
>
> Fixes: 28a65567acb5 ("KVM: selftests: Drop now-unnecessary ucall_uninit()")
> Fixes: 35c581015712 ("KVM: selftests: aarch64: Add aarch64/page_fault_test")
> Signed-off-by: Mark Brown <broonie@kernel•org>
> Cc: Sean Christopherson <seanjc@google•com>
> Cc: Ricardo Koller <ricarkol@google•com>
> Cc: Marc Zyngier <maz@kernel•org>
> ---
> tools/testing/selftests/kvm/aarch64/page_fault_test.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/testing/selftests/kvm/aarch64/page_fault_test.c b/tools/testing/selftests/kvm/aarch64/page_fault_test.c
> index 05bb6a6369c2..4ef89c57a937 100644
> --- a/tools/testing/selftests/kvm/aarch64/page_fault_test.c
> +++ b/tools/testing/selftests/kvm/aarch64/page_fault_test.c
> @@ -722,7 +722,6 @@ static void run_test(enum vm_guest_mode mode, void *arg)
>
> vcpu_run_loop(vm, vcpu, test);
>
> - ucall_uninit(vm);
> kvm_vm_free(vm);
> free_uffd(test, pt_uffd, data_uffd);
>
> --
> 2.30.2
>
Also added to my merge of the kvm-arm tree.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2022-12-06 20:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 18:15 [PATCH] KVM: selftests: Fix build due to ucall_uninit() removal Mark Brown
2022-12-06 20:49 ` Stephen Rothwell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221207074904.2f9d04ed@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=broonie@kernel$(echo .)org \
--cc=kvm@vger$(echo .)kernel.org \
--cc=kvmarm@lists$(echo .)linux.dev \
--cc=linux-kselftest@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=maz@kernel$(echo .)org \
--cc=pbonzini@redhat$(echo .)com \
--cc=ricarkol@google$(echo .)com \
--cc=seanjc@google$(echo .)com \
--cc=shuah@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox