From: "Michael S. Tsirkin" <mst@redhat•com>
To: "Ricardo Cañuelo" <ricardo.canuelo@collabora•com>
Cc: Bagas Sanjaya <bagasdotme@gmail•com>,
sfr@canb•auug.org.au, linux-kernel@vger•kernel.org,
linux-next@vger•kernel.org,
virtualization@lists•linux-foundation.org, kernel@collabora•com
Subject: Re: [PATCH] virtio: fix virtio_config_ops kerneldocs
Date: Tue, 20 Dec 2022 05:25:04 -0500 [thread overview]
Message-ID: <20221220052333-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <bf9bd0ba-c703-1903-7df2-ac95dea0f3e8@collabora.com>
On Tue, Dec 20, 2022 at 10:54:17AM +0100, Ricardo Cañuelo wrote:
> Hi Bagas,
>
> Thanks for the review, some comments below:
>
> On 20/12/22 10:12, Bagas Sanjaya wrote:> On Tue, Dec 20, 2022 at 08:37:09AM +0100, Ricardo Cañuelo wrote:
> > Describe the steps needed to fix both warnings above. I see in the diff that:
> >
> > * move vq_callback_t() declaration above;
> > * match entity type of virtio_config_ops; and
> > * reformat @finalize_features description.
>
> I wouldn't like to add redundant info in the commit message for
> such a trivial patch. The commit message describes _what_ the
> patch does. The _how_ is just as clear in the patch itself as in
> this description, IMO.
Yea it's overkill for this patch.
> >
> > > Signed-off-by: Ricardo Cañuelo <ricardo.canuelo@collabora•com>
> >
> > You need to add appropriate tags:
> >
> > Link: https://lore.kernel.org/linux-next/20221220105956.4786852d@canb.auug.org.au/
> > Fixes: 333723e8bc393d ("docs: driver-api: virtio: virtio on Linux")
> > Reported-by: Stephen Rothwell <sfr@canb•auug.org.au>
>
> Thanks for the tip although, actually, it's not that commit that
> needs to be fixed but the kerneldoc itself.
This doesn't matter I think, what Fixes tag does is tell tools
if you have commit A you want this one on top.
> The warnings were
> made visible after that commit but not introduced by it. I'll add
> the Reported-by tag in v2.
>
> Cheers,
> Ricardo
next prev parent reply other threads:[~2022-12-20 10:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-20 7:37 [PATCH] virtio: fix virtio_config_ops kerneldocs Ricardo Cañuelo
2022-12-20 9:12 ` Bagas Sanjaya
2022-12-20 9:54 ` Ricardo Cañuelo
2022-12-20 10:25 ` Michael S. Tsirkin [this message]
2022-12-20 11:30 ` Ricardo Cañuelo
2022-12-20 9:48 ` AngeloGioacchino Del Regno
2022-12-20 10:01 ` Ricardo Cañuelo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221220052333-mutt-send-email-mst@kernel.org \
--to=mst@redhat$(echo .)com \
--cc=bagasdotme@gmail$(echo .)com \
--cc=kernel@collabora$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=ricardo.canuelo@collabora$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=virtualization@lists$(echo .)linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox