public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Rob Herring <robherring2@gmail•com>
Cc: Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
	Linux Next Mailing List <linux-next@vger•kernel.org>
Subject: linux-next: build failures after merge of the devicetree tree
Date: Tue, 11 Apr 2023 16:20:53 +1000	[thread overview]
Message-ID: <20230411162053.0adfd01a@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 2006 bytes --]

Hi all,

After merging the devicetree tree, today's linux-next build (i386
defconfig) failed like this:

In file included from kernel/irq/irqdomain.c:15:
include/linux/of_address.h:111:12: error: 'of_property_read_reg' defined but not used [-Werror=unused-function]
  111 | static int of_property_read_reg(struct device_node *np, int idx, u64 *addr, u64 *size)
      |            ^~~~~~~~~~~~~~~~~~~~
In file included from drivers/base/property.c:14:
include/linux/of_address.h:111:12: error: 'of_property_read_reg' defined but not used [-Werror=unused-function]
  111 | static int of_property_read_reg(struct device_node *np, int idx, u64 *addr, u64 *size)
      |            ^~~~~~~~~~~~~~~~~~~~
In file included from lib/devres.c:7:
include/linux/of_address.h:111:12: error: 'of_property_read_reg' defined but not used [-Werror=unused-function]
  111 | static int of_property_read_reg(struct device_node *np, int idx, u64 *addr, u64 *size)
      |            ^~~~~~~~~~~~~~~~~~~~

Introduced by commit

  87b764b15f9a ("of/address: Add of_property_read_reg() helper")

I applied the following fix patch:

From: Stephen Rothwell <sfr@canb•auug.org.au>
Date: Tue, 11 Apr 2023 16:09:19 +1000
Subject: [PATCH] of/address: fixup for "Add of_property_read_reg() helper"

Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
---
 include/linux/of_address.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/of_address.h b/include/linux/of_address.h
index 95cb6c5c2d67..26a19daf0d09 100644
--- a/include/linux/of_address.h
+++ b/include/linux/of_address.h
@@ -108,7 +108,7 @@ static inline const __be32 *__of_get_address(struct device_node *dev, int index,
 	return NULL;
 }
 
-static int of_property_read_reg(struct device_node *np, int idx, u64 *addr, u64 *size)
+static inline int of_property_read_reg(struct device_node *np, int idx, u64 *addr, u64 *size)
 {
 	return -ENOSYS;
 }
-- 
2.39.2

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

                 reply	other threads:[~2023-04-11  6:21 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230411162053.0adfd01a@canb.auug.org.au \
    --to=sfr@canb$(echo .)auug.org.au \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=robherring2@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox