From: Conor Dooley <conor.dooley@microchip•com>
To: Herbert Xu <herbert@gondor•apana.org.au>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
Linux Crypto List <linux-crypto@vger•kernel.org>,
Huan Feng <huan.feng@starfivetech•com>,
Jia Jie Ho <jiajie.ho@starfivetech•com>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Linux Next Mailing List <linux-next@vger•kernel.org>
Subject: Re: [PATCH] crypto: starfive - Depend on AMBA_PL08X instead of selecting it
Date: Tue, 23 May 2023 07:56:39 +0100 [thread overview]
Message-ID: <20230523-pelvis-unwritten-bedc9c75d899@wendy> (raw)
In-Reply-To: <ZGwmAp5RPqAjVMCg@gondor.apana.org.au>
[-- Attachment #1: Type: text/plain, Size: 1696 bytes --]
On Tue, May 23, 2023 at 10:33:38AM +0800, Herbert Xu wrote:
> On Tue, May 23, 2023 at 10:36:37AM +1000, Stephen Rothwell wrote:
> >
> > That did not fix it :-(
>
> OK, this patch should fix it:
>
> ---8<---
> A platform option like AMBA should never be selected by a driver.
> Use a dependency instead.
Randy submitted a patch to change the driver to not conflict with
the arch symbols:
https://lore.kernel.org/all/20230523000606.9405-1-rdunlap@infradead.org/
The corresponding change here makes sense to me,
Reviewed-by: Conor Dooley <conor.dooley@microchip•com>
@StarFive folks, you will need to go and submit a patch for
arch/riscv/Kconfig.socs that selects ARM_AMBA for your platform.
> Also remove the depenency on DMADEVICES because the driver builds
> just fine without it. Instead add a dependency on HAS_DMA for dma
> mapping support.
>
> Reported-by: Stephen Rothwell <sfr@canb•auug.org.au>
> Reported-by: Conor Dooley <conor.dooley@microchip•com>
> Signed-off-by: Herbert Xu <herbert@gondor•apana.org.au>
>
> diff --git a/drivers/crypto/starfive/Kconfig b/drivers/crypto/starfive/Kconfig
> index 908c162ba79a..59002abcc0ad 100644
> --- a/drivers/crypto/starfive/Kconfig
> +++ b/drivers/crypto/starfive/Kconfig
> @@ -4,14 +4,13 @@
>
> config CRYPTO_DEV_JH7110
> tristate "StarFive JH7110 cryptographic engine driver"
> - depends on (SOC_STARFIVE || COMPILE_TEST) && DMADEVICES
> + depends on SOC_STARFIVE || AMBA_PL08X || COMPILE_TEST
While we are changing everything, would you mind doing s/SOC/ARCH/ here?
I didn't notice that while the series was being reviewed. Otherwise,
I'll send you a patch for it.
Cheers,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-05-23 6:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 0:52 linux-next: build failure after merge of the crypto tree Stephen Rothwell
2023-05-22 5:15 ` Herbert Xu
2023-05-23 0:36 ` Stephen Rothwell
2023-05-23 2:33 ` [PATCH] crypto: starfive - Depend on AMBA_PL08X instead of selecting it Herbert Xu
2023-05-23 6:56 ` Conor Dooley [this message]
2023-05-23 7:31 ` Jia Jie Ho
2023-05-25 1:25 ` Stephen Rothwell
2023-06-06 9:12 ` Geert Uytterhoeven
2023-06-06 9:31 ` Herbert Xu
2023-06-06 9:34 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230523-pelvis-unwritten-bedc9c75d899@wendy \
--to=conor.dooley@microchip$(echo .)com \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=huan.feng@starfivetech$(echo .)com \
--cc=jiajie.ho@starfivetech$(echo .)com \
--cc=linux-crypto@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox