From: Conor Dooley <conor@kernel•org>
To: "Björn Töpel" <bjorn@kernel•org>
Cc: "Paul Walmsley" <paul.walmsley@sifive•com>,
"Palmer Dabbelt" <palmer@dabbelt•com>,
"Albert Ou" <aou@eecs•berkeley.edu>,
linux-riscv@lists•infradead.org,
"Randy Dunlap" <rdunlap@infradead•org>,
"Björn Töpel" <bjorn@rivosinc•com>,
linux-kernel@vger•kernel.org, "Guo Ren" <guoren@kernel•org>,
"Drew Fustini" <dfustini@baylibre•com>,
linux-next@vger•kernel.org,
"Stephen Rothwell" <sfr@canb•auug.org.au>
Subject: Re: [PATCH] riscv: Require FRAME_POINTER for some configurations
Date: Wed, 23 Aug 2023 16:44:24 +0100 [thread overview]
Message-ID: <20230823-disown-footman-e326acc3270c@spud> (raw)
In-Reply-To: <20230823082845.354839-1-bjorn@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 2115 bytes --]
On Wed, Aug 23, 2023 at 10:28:45AM +0200, Björn Töpel wrote:
> From: Björn Töpel <bjorn@rivosinc•com>
>
> Some V configurations implicitly turn on '-fno-omit-frame-pointer',
> but leaving FRAME_POINTER disabled. This makes it hard to reason about
> the FRAME_POINTER config, and also triggers build failures introduced
> in by the commit in the Fixes: tag.
>
> Select FRAME_POINTER explicitly for these configurations.
>
> Fixes: ebc9cb03b21e ("riscv: stack: Fixup independent softirq stack for CONFIG_FRAME_POINTER=n")
> Signed-off-by: Björn Töpel <bjorn@rivosinc•com>
I think this is reasonable, even if you pre-patch version of this seemed
quite sceptical.
Reviewed-by: Conor Dooley <conor.dooley@microchip•com>
Thanks,
Conor.
> ---
> arch/riscv/Kconfig | 1 +
> arch/riscv/Makefile | 3 ---
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> index 10e7a7ad175a..cd8075c092c3 100644
> --- a/arch/riscv/Kconfig
> +++ b/arch/riscv/Kconfig
> @@ -62,6 +62,7 @@ config RISCV
> select COMMON_CLK
> select CPU_PM if CPU_IDLE || HIBERNATION
> select EDAC_SUPPORT
> + select FRAME_POINTER if PERF_EVENTS || (FUNCTION_TRACER && !DYNAMIC_FTRACE)
> select GENERIC_ARCH_TOPOLOGY
> select GENERIC_ATOMIC64 if !64BIT
> select GENERIC_CLOCKEVENTS_BROADCAST if SMP
> diff --git a/arch/riscv/Makefile b/arch/riscv/Makefile
> index 6ec6d52a4180..1329e060c548 100644
> --- a/arch/riscv/Makefile
> +++ b/arch/riscv/Makefile
> @@ -87,9 +87,6 @@ endif
> ifeq ($(CONFIG_CMODEL_MEDANY),y)
> KBUILD_CFLAGS += -mcmodel=medany
> endif
> -ifeq ($(CONFIG_PERF_EVENTS),y)
> - KBUILD_CFLAGS += -fno-omit-frame-pointer
> -endif
>
> # Avoid generating .eh_frame sections.
> KBUILD_CFLAGS += -fno-asynchronous-unwind-tables -fno-unwind-tables
>
> base-commit: 89bf6209cad66214d3774dac86b6bbf2aec6a30d
> --
> 2.39.2
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists•infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-08-23 15:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-23 8:28 [PATCH] riscv: Require FRAME_POINTER for some configurations Björn Töpel
2023-08-23 8:49 ` Björn Töpel
2023-08-23 15:34 ` Randy Dunlap
2023-08-23 15:44 ` Conor Dooley [this message]
2023-08-23 20:10 ` patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230823-disown-footman-e326acc3270c@spud \
--to=conor@kernel$(echo .)org \
--cc=aou@eecs$(echo .)berkeley.edu \
--cc=bjorn@kernel$(echo .)org \
--cc=bjorn@rivosinc$(echo .)com \
--cc=dfustini@baylibre$(echo .)com \
--cc=guoren@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-riscv@lists$(echo .)infradead.org \
--cc=palmer@dabbelt$(echo .)com \
--cc=paul.walmsley@sifive$(echo .)com \
--cc=rdunlap@infradead$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox