Subject: Re: linux-next: build failure after merge of the bcachefs tree

From: Stephen Rothwell <[email-masked]>
Date: Thu, 14 Sep 2023 08:14:00 +1000

Hi all,

On Tue, 12 Sep 2023 12:04:29 +1000 Stephen Rothwell <[email-masked]> wrote:
> 
> After merging the bcachefs tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> fs/bcachefs/btree_cache.c: In function 'bch2_fs_btree_cache_exit':
> fs/bcachefs/btree_cache.c:403:9: error: implicit declaration of function 'unregister_shrinker'; did you mean 'unregister_chrdev'? [-Werror=implicit-function-declaration]
>   403 |         unregister_shrinker(&bc->shrink);
>       |         ^~~~~~~~~~~~~~~~~~~
>       |         unregister_chrdev
> fs/bcachefs/btree_cache.c: In function 'bch2_fs_btree_cache_init':
> fs/bcachefs/btree_cache.c:479:15: error: implicit declaration of function 'register_shrinker'; did you mean 'register_chrdev'? [-Werror=implicit-function-declaration]
>   479 |         ret = register_shrinker(&bc->shrink, "%s/btree_cache", c->name);
>       |               ^~~~~~~~~~~~~~~~~
>       |               register_chrdev
> cc1: all warnings being treated as errors
> 
> Caused by commits
> 
>   5ec30115c066 ("bcachefs: Initial commit")
> 
> interacting with commit
> 
>   eba045d9350d ("mm: shrinker: remove old APIs")
> 
> from v6.6-rc1.

This latter commit is actually in the mm tree and is now commit

  d3ed57149dec ("mm: shrinker: remove old APIs")

-- 
Cheers,
Stephen Rothwell