public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Tejun Heo <tj@kernel•org>
Cc: Waiman Long <longman@redhat•com>,
	Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
	Linux Next Mailing List <linux-next@vger•kernel.org>
Subject: linux-next: build failure after merge of the cgroup tree
Date: Thu, 7 Dec 2023 14:38:06 +1100	[thread overview]
Message-ID: <20231207143806.114e0a74@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 3999 bytes --]

Hi all,

After merging the cgroup tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from <command-line>:
kernel/cgroup/cgroup.c: In function 'cgroup_free_root':
include/linux/compiler_types.h:435:45: error: call to '__compiletime_assert_1792' declared with attribute error: BUILD_BUG_ON failed: !__is_kvfree_rcu_offset(offsetof(typeof(*(root)), rcu))
  435 |         _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
      |                                             ^
include/linux/compiler_types.h:416:25: note: in definition of macro '__compiletime_assert'
  416 |                         prefix ## suffix();                             \
      |                         ^~~~~~
include/linux/compiler_types.h:435:9: note: in expansion of macro '_compiletime_assert'
  435 |         _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
      |         ^~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert'
   39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
      |                                     ^~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:50:9: note: in expansion of macro 'BUILD_BUG_ON_MSG'
   50 |         BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition)
      |         ^~~~~~~~~~~~~~~~
include/linux/rcupdate.h:985:17: note: in expansion of macro 'BUILD_BUG_ON'
  985 |                 BUILD_BUG_ON(!__is_kvfree_rcu_offset(offsetof(typeof(*(ptr)), rhf)));   \
      |                 ^~~~~~~~~~~~
include/linux/rcupdate.h:957:29: note: in expansion of macro 'kvfree_rcu_arg_2'
  957 | #define kfree_rcu(ptr, rhf) kvfree_rcu_arg_2(ptr, rhf)
      |                             ^~~~~~~~~~~~~~~~
kernel/cgroup/cgroup.c:1318:9: note: in expansion of macro 'kfree_rcu'
 1318 |         kfree_rcu(root, rcu);
      |         ^~~~~~~~~
In function 'cgroup_free_root',
    inlined from 'cgroup_destroy_root' at kernel/cgroup/cgroup.c:1363:2:
include/linux/compiler_types.h:435:45: error: call to '__compiletime_assert_1792' declared with attribute error: BUILD_BUG_ON failed: !__is_kvfree_rcu_offset(offsetof(typeof(*(root)), rcu))
  435 |         _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
      |                                             ^
include/linux/compiler_types.h:416:25: note: in definition of macro '__compiletime_assert'
  416 |                         prefix ## suffix();                             \
      |                         ^~~~~~
include/linux/compiler_types.h:435:9: note: in expansion of macro '_compiletime_assert'
  435 |         _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
      |         ^~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert'
   39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
      |                                     ^~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:50:9: note: in expansion of macro 'BUILD_BUG_ON_MSG'
   50 |         BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition)
      |         ^~~~~~~~~~~~~~~~
include/linux/rcupdate.h:985:17: note: in expansion of macro 'BUILD_BUG_ON'
  985 |                 BUILD_BUG_ON(!__is_kvfree_rcu_offset(offsetof(typeof(*(ptr)), rhf)));   \
      |                 ^~~~~~~~~~~~
include/linux/rcupdate.h:957:29: note: in expansion of macro 'kvfree_rcu_arg_2'
  957 | #define kfree_rcu(ptr, rhf) kvfree_rcu_arg_2(ptr, rhf)
      |                             ^~~~~~~~~~~~~~~~
kernel/cgroup/cgroup.c:1318:9: note: in expansion of macro 'kfree_rcu'
 1318 |         kfree_rcu(root, rcu);
      |         ^~~~~~~~~

Possibly caused by commit

  77070eeb8821 ("cgroup: Avoid false cacheline sharing of read mostly rstat_cpu")

I have used the cgroup tree from next-20231206 for today.



-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

             reply	other threads:[~2023-12-07  3:38 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-07  3:38 Stephen Rothwell [this message]
2023-12-07  4:18 ` linux-next: build failure after merge of the cgroup tree Waiman Long
  -- strict thread matches above, loose matches on Subject: below --
2025-08-25  5:03 Stephen Rothwell
2025-08-25 18:18 ` Tejun Heo
2024-07-12  6:43 Stephen Rothwell
2024-07-12  6:51 ` Stephen Rothwell
2024-07-12 14:48   ` Jonathan Corbet
2024-07-12 16:44     ` Tejun Heo
2024-07-12 16:50       ` Tejun Heo
2023-07-17  1:34 Stephen Rothwell
2023-07-17  6:45 ` Miaohe Lin
2022-10-31  2:23 Stephen Rothwell
2022-10-31 17:52 ` Tejun Heo
2022-09-12  6:18 Stephen Rothwell
2022-09-12  7:38 ` Peter Zijlstra
2022-09-12 18:44   ` Tejun Heo
2022-09-12 22:16     ` Tejun Heo
2022-09-15 10:46       ` Peter Zijlstra
2022-10-10 20:57 ` Stephen Rothwell
2022-10-10 20:59   ` Tejun Heo
2022-08-29  3:29 Stephen Rothwell
2021-05-11  0:51 Stephen Rothwell
2021-05-11  1:10 ` Roman Gushchin
2021-05-11  1:31   ` Tejun Heo
2021-04-22  6:31 Stephen Rothwell
2015-09-25  3:26 Stephen Rothwell
2014-02-26  6:46 Stephen Rothwell
2014-02-26 13:44 ` Tejun Heo
2013-04-29  4:04 Stephen Rothwell
2013-04-29 22:55 ` Tejun Heo
2013-04-30  1:51   ` Benjamin Herrenschmidt
2012-09-14  3:17 Stephen Rothwell
2012-09-14  6:56 ` Daniel Wagner
2012-09-14 17:00   ` Tejun Heo
2012-09-14 18:32     ` Sedat Dilek
2012-09-14 18:34       ` Tejun Heo
2012-09-15  7:55         ` Sedat Dilek
2011-11-25  3:50 Stephen Rothwell
2011-11-27 19:33 ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231207143806.114e0a74@canb.auug.org.au \
    --to=sfr@canb$(echo .)auug.org.au \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=longman@redhat$(echo .)com \
    --cc=tj@kernel$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox