public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro•org>
Cc: Miquel Raynal <miquel.raynal@bootlin•com>,
	Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
	Linux Next Mailing List <linux-next@vger•kernel.org>
Subject: linux-next: build failure after merge of the nvmem tree
Date: Mon, 11 Dec 2023 16:49:16 +1100	[thread overview]
Message-ID: <20231211164916.6f0d2357@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 1377 bytes --]

Hi all,

After merging the nvmem tree, today's linux-next build (i386 defconfig)
failed like this:

/home/sfr/next/next/drivers/nvmem/core.c: In function 'nvmem_cell_put':
/home/sfr/next/next/drivers/nvmem/core.c:1603:9: error: implicit declaration of function 'nvmem_layout_module_put' [-Werror=implicit-function-declaration]
 1603 |         nvmem_layout_module_put(nvmem);
      |         ^~~~~~~~~~~~~~~~~~~~~~~

Caused by commit

  ed7778e43271 ("nvmem: core: Rework layouts to become regular devices")

I have applied the following patch for today.

From: Stephen Rothwell <sfr@canb•auug.org.au>
Date: Mon, 11 Dec 2023 16:34:34 +1100
Subject: [PATCH] fix up for "nvmem: core: Rework layouts to become regular devices"

Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
---
 drivers/nvmem/core.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
index 9fc452e8ada8..784b61eb4d8e 100644
--- a/drivers/nvmem/core.c
+++ b/drivers/nvmem/core.c
@@ -1491,6 +1491,11 @@ struct nvmem_cell *of_nvmem_cell_get(struct device_node *np, const char *id)
 	return cell;
 }
 EXPORT_SYMBOL_GPL(of_nvmem_cell_get);
+
+#else /* IS_ENABLED(CONFIG_OF) */
+
+static inline void nvmem_layout_module_put(struct nvmem_device *nvmem) { }
+
 #endif
 
 /**
-- 
2.40.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

             reply	other threads:[~2023-12-11  5:49 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-11  5:49 Stephen Rothwell [this message]
2023-12-11 10:23 ` linux-next: build failure after merge of the nvmem tree Srinivas Kandagatla
2023-12-11 10:30   ` Miquel Raynal
2023-12-11 11:10     ` Srinivas Kandagatla
2023-12-11 13:53       ` Miquel Raynal
  -- strict thread matches above, loose matches on Subject: below --
2025-08-19  3:40 Stephen Rothwell
2025-08-19 11:14 ` Heiko Stübner
2025-08-19 11:22   ` Srinivas Kandagatla
2025-08-19 13:54     ` Heiko Stübner
2025-08-19 13:58       ` Srinivas Kandagatla
2025-08-19 14:49         ` Heiko Stübner
2025-08-20  7:14           ` Lee Jones
2023-08-15 10:25 Stephen Rothwell
2023-08-20 23:48 ` Stephen Rothwell
2023-08-21  5:27   ` Komal Bajaj
2022-11-01  3:21 Stephen Rothwell
2022-11-01  7:27 ` Srinivas Kandagatla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231211164916.6f0d2357@canb.auug.org.au \
    --to=sfr@canb$(echo .)auug.org.au \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=miquel.raynal@bootlin$(echo .)com \
    --cc=srinivas.kandagatla@linaro$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox