From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Florian Eckert <fe@dev•tdt.de>
Cc: Jonathan Corbet <corbet@lwn•net>, Lee Jones <lee@kernel•org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Linux Next Mailing List <linux-next@vger•kernel.org>
Subject: Re: linux-next: build warning after merge of the leds-lj tree
Date: Thu, 25 Jan 2024 11:38:14 +1100 [thread overview]
Message-ID: <20240125113814.532f1fb5@canb.auug.org.au> (raw)
In-Reply-To: <20240109222031.6ce4aecc@canb.auug.org.au>
[-- Attachment #1: Type: text/plain, Size: 2027 bytes --]
Hi all,
On Tue, 9 Jan 2024 22:20:31 +1100 Stephen Rothwell <sfr@canb•auug.org.au> wrote:
>
> On Mon, 08 Jan 2024 08:47:07 +0100 Florian Eckert <fe@dev•tdt.de> wrote:
> >
> > thanks for your hint
> >
> > On 2024-01-05 07:33, Stephen Rothwell wrote:
> > > Hi all,
> > >
> > > After merging the leds-lj tree, today's linux-next build (htmldocs)
> > > produced this warning:
> > >
> > > Warning: /sys/class/leds/<led>/rx is defined 2 times: Documentation/ABI/testing/sysfs-class-led-trigger-tty:7 Documentation/ABI/testing/sysfs-class-led-trigger-netdev:49
> > > Warning: /sys/class/leds/<led>/tx is defined 2 times: Documentation/ABI/testing/sysfs-class-led-trigger-tty:15 Documentation/ABI/testing/sysfs-class-led-trigger-netdev:34
> >
> > The behavior of the tty trigger can be controlled via the Rx and Tx file.
> > If a value is set in Rx or Tx, the LED flashes when data is transmitted in
> > this direction. The same behavior is used for the netdev trigger.
> > I have therefore used the same pattern for the new tty trigger as well.
> >
> > I didn't know that the names have to be unique!
> >
> > I'm a bit at a loss as to what to do now. Should I put a prefix "tty_"
> > in front of the names so that we have "tty_rx", "tty_tx"?
> >
> > If we do it this way, however, the general question arises as to whether
> > we do have to use a prefix everywhere! If new triggers are added, then the
> > names for a config file are already used up and anyone who then wants to use
> > the same name for an other trigger with the same config file because it describe
> > the same function must then work with a prefix!
>
> I think this is only a problem with the documentation system, not the
> actual sysfs file naming. Maybe just adding a uniquifying bit to the
> "<led>" part will solve it. Or maybe we need the tooling to be taught
> about placeholders in sysfs names (or maybe there is already a way).
I am still seeing these warnings.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-01-25 0:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-05 6:33 linux-next: build warning after merge of the leds-lj tree Stephen Rothwell
2024-01-08 7:47 ` Florian Eckert
2024-01-09 11:20 ` Stephen Rothwell
2024-01-25 0:38 ` Stephen Rothwell [this message]
2024-02-08 23:20 ` Jonathan Corbet
2024-02-09 8:02 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240125113814.532f1fb5@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=corbet@lwn$(echo .)net \
--cc=fe@dev$(echo .)tdt.de \
--cc=lee@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox