From: Bjorn Helgaas <helgaas@kernel•org>
To: Johan Hovold <johan@kernel•org>
Cc: "Stephen Rothwell" <sfr@canb•auug.org.au>,
"Bjorn Helgaas" <bhelgaas@google•com>,
"Lorenzo Pieralisi" <lpieralisi@kernel•org>,
"Krzysztof Wilczyński" <kw@linux•com>,
"Johan Hovold" <johan+linaro@kernel•org>,
"Linux Kernel Mailing List" <linux-kernel@vger•kernel.org>,
"Linux Next Mailing List" <linux-next@vger•kernel.org>
Subject: Re: linux-next: build warning after merge of the pci-current tree
Date: Wed, 31 Jan 2024 09:07:34 -0600 [thread overview]
Message-ID: <20240131150734.GA585821@bhelgaas> (raw)
In-Reply-To: <Zbn58XcoOXauLUjN@hovoldconsulting.com>
On Wed, Jan 31, 2024 at 08:42:41AM +0100, Johan Hovold wrote:
> On Wed, Jan 31, 2024 at 12:58:43PM +1100, Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the pci-current tree, today's linux-next build (htmldocs)
> > produced this warning:
> >
> > drivers/pci/bus.c:440: warning: Function parameter or struct member 'top' not described in 'pci_walk_bus'
> > drivers/pci/bus.c:440: warning: Function parameter or struct member 'cb' not described in 'pci_walk_bus'
> > drivers/pci/bus.c:440: warning: Function parameter or struct member 'userdata' not described in 'pci_walk_bus'
> >
> > Introduced by commit
> >
> > 69fb843fdbd9 ("PCI/ASPM: Fix deadlock when enabling ASPM")
>
> Bah, I added a newline after the opening /** when moving a comment
> without noticing that the kernel doc comment was malformed.
>
> Bjorn, you could either remove that newline or squash the below patch
> address this.
Squashed in, thanks!
> diff --git a/drivers/pci/bus.c b/drivers/pci/bus.c
> index 116415f91195..826b5016a101 100644
> --- a/drivers/pci/bus.c
> +++ b/drivers/pci/bus.c
> @@ -425,9 +425,9 @@ static void __pci_walk_bus(struct pci_bus *top, int (*cb)(struct pci_dev *, void
>
> /**
> * pci_walk_bus - walk devices on/under bus, calling callback.
> - * @top bus whose devices should be walked
> - * @cb callback to be called for each device found
> - * @userdata arbitrary pointer to be passed to callback.
> + * @top: bus whose devices should be walked
> + * @cb: callback to be called for each device found
> + * @userdata: arbitrary pointer to be passed to callback
> *
> * Walk the given bus, including any bridged devices
> * on buses under this bus. Call the provided callback
next prev parent reply other threads:[~2024-01-31 15:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 1:58 linux-next: build warning after merge of the pci-current tree Stephen Rothwell
2024-01-31 7:42 ` Johan Hovold
2024-01-31 15:07 ` Bjorn Helgaas [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-11-16 23:02 Stephen Rothwell
2012-11-05 23:05 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240131150734.GA585821@bhelgaas \
--to=helgaas@kernel$(echo .)org \
--cc=bhelgaas@google$(echo .)com \
--cc=johan+linaro@kernel$(echo .)org \
--cc=johan@kernel$(echo .)org \
--cc=kw@linux$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=lpieralisi@kernel$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox