From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Lee Jones <lee@kernel•org>
Cc: "Duje Mihanović" <duje.mihanovic@skole•hr>,
"Linux Kernel Mailing List" <linux-kernel@vger•kernel.org>,
"Linux Next Mailing List" <linux-next@vger•kernel.org>
Subject: Re: linux-next: build failure after merge of the backlight tree
Date: Wed, 6 Mar 2024 14:04:27 +1100 [thread overview]
Message-ID: <20240306140427.4cb24a5e@canb.auug.org.au> (raw)
In-Reply-To: <20240306095539.0da4e342@canb.auug.org.au>
[-- Attachment #1: Type: text/plain, Size: 1935 bytes --]
Hi Lee,
On Wed, 6 Mar 2024 09:55:39 +1100 Stephen Rothwell <sfr@canb•auug.org.au> wrote:
>
> On Tue, 5 Mar 2024 09:17:37 +0000 Lee Jones <lee@kernel•org> wrote:
> > On Tue, 05 Mar 2024, Stephen Rothwell wrote:
> > > On Mon, 26 Feb 2024 13:28:28 +1100 Stephen Rothwell <sfr@canb•auug.org.au> wrote:
> > > >
> > > > After merging the backlight tree, today's linux-next build (x86_64
> > > > allmodconfig) failed like this:
> > > >
> > > > drivers/video/backlight/ktd2801-backlight.c:8:10: fatal error: linux/leds-expresswire.h: No such file or directory
> > > > 8 | #include <linux/leds-expresswire.h>
> > > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> > > >
> > > > Caused by commit
> > > >
> > > > 48749e2f14e3 ("backlight: Add Kinetic KTD2801 backlight support")
> > > >
> > > > I have used the backlight tree from next-20240223 for today.
> > >
> > > I am still getting this failure.
> >
> > I just pushed a bunch of patches.
>
> I saw only 3 new ones (forgot to push?) none of which addressed this
> problem.
>
> > Please let me know if this is still an issue tomorrow.
>
> The problem is that after Feb 23, you rebased your tree and dropped commit
>
> 25ae5f5f4168 ("leds: Introduce ExpressWire library")
>
> which (added the leds-expresswire.h header), but kept commit
>
> 48749e2f14e3 ("backlight: Add Kinetic KTD2801 backlight support")
>
> which uses it.
Now I see what happened. I have 2 trees from you, the backlight tree
(git://git.kernel.org/pub/scm/linux/kernel/git/lee/backlight.git#for-backlight-next)
and the leds-lj tree
(git://git.kernel.org/pub/scm/linux/kernel/git/lee/leds.git#for-leds-next)
and the former implicitly depends on the latter (and I merge the
backlight tree first). You should make that dependency explicit by
merging (part of) the latter into the former (or something).
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-03-06 3:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 2:28 linux-next: build failure after merge of the backlight tree Stephen Rothwell
2024-03-05 0:16 ` Stephen Rothwell
2024-03-05 9:17 ` Lee Jones
2024-03-05 22:55 ` Stephen Rothwell
2024-03-06 3:04 ` Stephen Rothwell [this message]
2024-03-07 8:24 ` Lee Jones
2024-03-07 9:04 ` Lee Jones
2024-03-07 19:30 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2015-05-27 3:11 Stephen Rothwell
2015-05-27 7:45 ` Lee Jones
2010-05-10 2:43 Stephen Rothwell
2010-05-10 5:41 ` Mike Frysinger
2010-05-17 3:32 ` Stephen Rothwell
2010-05-18 15:54 ` Richard Purdie
2010-05-19 0:56 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240306140427.4cb24a5e@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=duje.mihanovic@skole$(echo .)hr \
--cc=lee@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox