From: coverity-bot <keescook@chromium•org>
To: Matthew Brost <matthew.brost@intel•com>
Cc: "Maarten Lankhorst" <maarten.lankhorst@linux•intel.com>,
"Matt Roper" <matthew.d.roper@intel•com>,
"Maxime Ripard" <mripard@kernel•org>,
"Thomas Hellström" <thomas.hellstrom@linux•intel.com>,
"Thomas Zimmermann" <tzimmermann@suse•de>,
"David Airlie" <airlied@gmail•com>,
intel-xe@lists•freedesktop.org,
"Oded Gabbay" <ogabbay@kernel•org>,
"Daniel Vetter" <daniel@ffwll•ch>,
dri-devel@lists•freedesktop.org,
"Lucas De Marchi" <lucas.demarchi@intel•com>,
linux-kernel@vger•kernel.org,
"Gustavo A. R. Silva" <gustavo@embeddedor•com>,
linux-next@vger•kernel.org, linux-hardening@vger•kernel.org
Subject: Coverity: xe_gt_tlb_invalidation_ggtt(): Error handling issues
Date: Thu, 7 Mar 2024 11:32:40 -0800 [thread overview]
Message-ID: <202403071132.198D11C@keescook> (raw)
Hello!
This is an experimental semi-automated report about issues detected by
Coverity from a scan of next-20240307 as part of the linux-next scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by commits:
Tue Mar 5 16:48:55 2024 -0800
27ee413bbc0b ("drm/xe: Do not grab forcewakes when issuing GGTT TLB invalidation via GuC")
Coverity reported the following:
*** CID 1584246: Error handling issues (CHECKED_RETURN)
drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c:250 in xe_gt_tlb_invalidation_ggtt()
244 seqno = xe_gt_tlb_invalidation_guc(gt);
245 if (seqno <= 0)
246 return seqno;
247
248 xe_gt_tlb_invalidation_wait(gt, seqno);
249 } else if (xe_device_uc_enabled(xe)) {
vvv CID 1584246: Error handling issues (CHECKED_RETURN)
vvv Calling "xe_force_wake_get" without checking return value (as is done elsewhere 15 out of 16 times).
250 xe_force_wake_get(gt_to_fw(gt), XE_FW_GT);
251 if (xe->info.platform == XE_PVC || GRAPHICS_VER(xe) >= 20) {
252 xe_mmio_write32(gt, PVC_GUC_TLB_INV_DESC1,
253 PVC_GUC_TLB_INV_DESC1_INVALIDATE);
254 xe_mmio_write32(gt, PVC_GUC_TLB_INV_DESC0,
255 PVC_GUC_TLB_INV_DESC0_VALID);
If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):
Reported-by: coverity-bot <keescook+coverity-bot@chromium•org>
Addresses-Coverity-ID: 1584246 ("Error handling issues")
Fixes: 27ee413bbc0b ("drm/xe: Do not grab forcewakes when issuing GGTT TLB invalidation via GuC")
Thanks for your attention!
--
Coverity-bot
reply other threads:[~2024-03-07 19:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202403071132.198D11C@keescook \
--to=keescook@chromium$(echo .)org \
--cc=airlied@gmail$(echo .)com \
--cc=daniel@ffwll$(echo .)ch \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=gustavo@embeddedor$(echo .)com \
--cc=intel-xe@lists$(echo .)freedesktop.org \
--cc=linux-hardening@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=lucas.demarchi@intel$(echo .)com \
--cc=maarten.lankhorst@linux$(echo .)intel.com \
--cc=matthew.brost@intel$(echo .)com \
--cc=matthew.d.roper@intel$(echo .)com \
--cc=mripard@kernel$(echo .)org \
--cc=ogabbay@kernel$(echo .)org \
--cc=thomas.hellstrom@linux$(echo .)intel.com \
--cc=tzimmermann@suse$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox