From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Andrew Morton <akpm@linux-foundation•org>
Cc: Qiang Zhang <qiang4.zhang@intel•com>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Linux Next Mailing List <linux-next@vger•kernel.org>
Subject: Re: linux-next: build warning after merge of the mm-hotfixes tree
Date: Wed, 17 Apr 2024 15:29:04 +1000 [thread overview]
Message-ID: <20240417152904.17fa874d@canb.auug.org.au> (raw)
In-Reply-To: <20240416115114.8f1673a2490d31f77d276a41@linux-foundation.org>
[-- Attachment #1: Type: text/plain, Size: 1600 bytes --]
Hi Andrew,
On Tue, 16 Apr 2024 11:51:14 -0700 Andrew Morton <akpm@linux-foundation•org> wrote:
>
> On Tue, 16 Apr 2024 17:35:25 +1000 Stephen Rothwell <sfr@canb•auug.org.au> wrote:
>
> > After merging the mm-hotfixes tree, today's linux-next build (htmldocs)
> > produced this warning:
> >
> > lib/bootconfig.c:911: warning: Function parameter or struct member 'early' not described in '_xbc_exit'
> > lib/bootconfig.c:911: warning: expecting prototype for xbc_exit(). Prototype was for _xbc_exit() instead
> >
> > Introduced by commit
> >
> > aaeda6237dec ("bootconfig: use memblock_free_late to free xbc memory to buddy")
> >
> > from the mm-hotfixes-unstable branch of the mm-hotfixes tree.
>
> Thanks. How's this?
>
> --- a/lib/bootconfig.c~bootconfig-use-memblock_free_late-to-free-xbc-memory-to-buddy-fix
> +++ a/lib/bootconfig.c
> @@ -901,7 +901,8 @@ static int __init xbc_parse_tree(void)
> }
>
> /**
> - * xbc_exit() - Clean up all parsed bootconfig
> + * _xbc_exit() - Clean up all parsed bootconfig
> + * @early: in early xbc init error
> *
> * This clears all data structures of parsed bootconfig on memory.
> * If you need to reuse xbc_init() with new boot config, you can
> _
>
OK, so the above two warnings went away, but now I get
lib/bootconfig.c:909: warning: expecting prototype for _xbc_exit(). Prototype was for xbc_exit() instead
Commit
aaeda6237dec ("bootconfig: use memblock_free_late to free xbc memory to buddy")
that was in the mm tree yesterday is not there now.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-04-17 5:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 7:35 linux-next: build warning after merge of the mm-hotfixes tree Stephen Rothwell
2024-04-16 18:51 ` Andrew Morton
2024-04-17 5:29 ` Stephen Rothwell [this message]
2024-04-17 20:53 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2024-08-08 3:58 Stephen Rothwell
2024-08-08 4:06 ` Pasha Tatashin
2023-07-25 3:55 Stephen Rothwell
2023-07-25 4:10 ` Hugh Dickins
2023-07-25 5:16 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240417152904.17fa874d@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=akpm@linux-foundation$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=qiang4.zhang@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox