From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Christian Brauner <brauner@kernel•org>
Cc: "Christian Göttsche" <cgzones@googlemail•com>,
"Arnd Bergmann" <arnd@arndb•de>,
"Linux Kernel Mailing List" <linux-kernel@vger•kernel.org>,
"Linux Next Mailing List" <linux-next@vger•kernel.org>
Subject: Re: linux-next: build warning after merge of the vfs-brauner tree
Date: Tue, 28 May 2024 13:31:04 +1000 [thread overview]
Message-ID: <20240528133104.304a1261@canb.auug.org.au> (raw)
In-Reply-To: <20240528104905.58195cbe@canb.auug.org.au>
[-- Attachment #1: Type: text/plain, Size: 2340 bytes --]
Hi all,
On Tue, 28 May 2024 10:49:05 +1000 Stephen Rothwell <sfr@canb•auug.org.au> wrote:
>
> After merging the vfs-brauner tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> fs/xattr.c: In function '__do_sys_setxattrat':
> fs/xattr.c:709:61: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> 709 | return do_setxattrat(dfd, pathname, at_flags, name, (const void __user *)args.value,
> | ^
> fs/xattr.c: In function '__do_sys_getxattrat':
> fs/xattr.c:855:61: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> 855 | return do_getxattrat(dfd, pathname, at_flags, name, (void __user *)args.value, args.size);
> | ^
>
> Introduced by commit
>
> 89345b0ac5ac ("fs/xattr: add *at family syscalls")
This became a build failure in the i386 defconfig build, so I applied
the following fix patch.
From: Stephen Rothwell <sfr@canb•auug.org.au>
Date: Tue, 28 May 2024 13:20:29 +1000
Subject: [PATCH] fix up for "fs/xattr: add *at family syscalls"
Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
---
fs/xattr.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/fs/xattr.c b/fs/xattr.c
index 8e712795ab80..d0d54ae2f9cb 100644
--- a/fs/xattr.c
+++ b/fs/xattr.c
@@ -706,7 +706,8 @@ SYSCALL_DEFINE6(setxattrat, int, dfd, const char __user *, pathname, unsigned in
if (error)
return error;
- return do_setxattrat(dfd, pathname, at_flags, name, (const void __user *)args.value,
+ return do_setxattrat(dfd, pathname, at_flags, name,
+ (const void __user *)(unsigned long)args.value,
args.size, args.flags);
}
@@ -852,7 +853,9 @@ SYSCALL_DEFINE6(getxattrat, int, dfd, const char __user *, pathname, unsigned in
if (args.flags != 0)
return -EINVAL;
- return do_getxattrat(dfd, pathname, at_flags, name, (void __user *)args.value, args.size);
+ return do_getxattrat(dfd, pathname, at_flags, name,
+ (void __user *)(unsigned long)args.value,
+ args.size);
}
SYSCALL_DEFINE4(getxattr, const char __user *, pathname,
--
2.43.0
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-05-28 3:31 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 0:49 linux-next: build warning after merge of the vfs-brauner tree Stephen Rothwell
2024-05-28 3:31 ` Stephen Rothwell [this message]
2024-05-28 12:30 ` Christian Brauner
2024-05-28 12:39 ` Arnd Bergmann
-- strict thread matches above, loose matches on Subject: below --
2025-11-12 2:46 Stephen Rothwell
2025-06-17 5:12 Stephen Rothwell
2025-08-01 4:38 ` Stephen Rothwell
2025-08-04 12:33 ` Christian Brauner
2025-02-28 7:55 Stephen Rothwell
2025-02-28 10:37 ` Christian Brauner
2025-02-19 4:34 Stephen Rothwell
2025-02-19 8:45 ` Bagas Sanjaya
2025-02-19 10:04 ` Christian Brauner
2025-02-19 11:23 ` Bagas Sanjaya
2025-02-19 21:12 ` NeilBrown
2024-10-30 5:24 Stephen Rothwell
2024-10-01 3:39 Stephen Rothwell
2024-10-01 15:05 ` Christian Brauner
2024-09-30 23:11 Stephen Rothwell
2024-10-01 4:19 ` Stephen Rothwell
2024-10-01 15:00 ` Christian Brauner
2024-10-07 22:58 ` Stephen Rothwell
2024-09-06 8:29 Stephen Rothwell
2024-09-18 5:24 ` Stephen Rothwell
2024-10-02 22:45 ` Stephen Rothwell
2024-10-03 9:11 ` Christian Brauner
2024-08-29 6:19 Stephen Rothwell
2024-08-26 6:01 Stephen Rothwell
2024-08-26 16:00 ` Pankaj Raghav (Samsung)
2024-08-13 3:40 Stephen Rothwell
2024-08-28 5:22 ` Stephen Rothwell
2024-08-01 5:55 Stephen Rothwell
2024-08-01 5:56 ` Stephen Rothwell
2024-08-01 5:01 Stephen Rothwell
2024-08-01 13:21 ` David Howells
2024-08-01 13:41 ` Christian Brauner
2024-03-05 23:51 Stephen Rothwell
2024-03-06 2:48 ` Linus Torvalds
2024-03-06 4:37 ` Stephen Rothwell
2024-03-06 4:47 ` Linus Torvalds
2024-03-06 9:55 ` Christian Brauner
2024-03-06 4:58 ` Stephen Rothwell
2024-01-17 2:39 Stephen Rothwell
2023-12-21 7:48 Stephen Rothwell
2023-12-21 13:19 ` David Howells
2023-11-24 2:13 Stephen Rothwell
2023-11-24 7:58 ` Amir Goldstein
2023-09-25 4:31 Stephen Rothwell
2023-08-15 11:15 Stephen Rothwell
2023-08-07 5:38 Stephen Rothwell
2023-07-31 3:58 Stephen Rothwell
2023-07-04 3:51 Stephen Rothwell
2023-05-24 3:46 Stephen Rothwell
2023-05-24 9:06 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240528133104.304a1261@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=arnd@arndb$(echo .)de \
--cc=brauner@kernel$(echo .)org \
--cc=cgzones@googlemail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox