From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Jiri Kosina <jikos@kernel•org>,
Benjamin Tissoires <benjamin.tissoires@redhat•com>
Cc: Benjamin Tissoires <bentiss@kernel•org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Linux Next Mailing List <linux-next@vger•kernel.org>
Subject: linux-next: build failure after merge of the hid tree
Date: Mon, 1 Jul 2024 18:51:04 +1000 [thread overview]
Message-ID: <20240701185104.52c159c1@canb.auug.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 2869 bytes --]
Hi all,
After merging the hid tree, today's linux-next build (i386 defconfig)
failed like this:
drivers/hid/hidraw.c: In function 'hidraw_send_report':
drivers/hid/hidraw.c:143:63: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
143 | ret = __hid_hw_output_report(dev, buf, count, (__u64)file, false);
| ^
drivers/hid/hidraw.c:154:56: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
154 | HID_REQ_SET_REPORT, (__u64)file, false);
| ^
drivers/hid/hidraw.c: In function 'hidraw_get_report':
drivers/hid/hidraw.c:231:56: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
231 | HID_REQ_GET_REPORT, (__u64)file, false);
| ^
cc1: all warnings being treated as errors
Caused by commit
67eccf151d76 ("HID: add source argument to HID low level functions")
I applied the following patch.
From: Stephen Rothwell <sfr@canb•auug.org.au>
Date: Mon, 1 Jul 2024 18:36:36 +1000
Subject: [PATCH] fix up for "HID: add source argument to HID low level
functions"
Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
---
drivers/hid/hidraw.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/hid/hidraw.c b/drivers/hid/hidraw.c
index c2396916cdaa..34633f99f3e4 100644
--- a/drivers/hid/hidraw.c
+++ b/drivers/hid/hidraw.c
@@ -140,7 +140,7 @@ static ssize_t hidraw_send_report(struct file *file, const char __user *buffer,
if ((report_type == HID_OUTPUT_REPORT) &&
!(dev->quirks & HID_QUIRK_NO_OUTPUT_REPORTS_ON_INTR_EP)) {
- ret = __hid_hw_output_report(dev, buf, count, (__u64)file, false);
+ ret = __hid_hw_output_report(dev, buf, count, (unsigned long)file, false);
/*
* compatibility with old implementation of USB-HID and I2C-HID:
* if the device does not support receiving output reports,
@@ -151,7 +151,7 @@ static ssize_t hidraw_send_report(struct file *file, const char __user *buffer,
}
ret = __hid_hw_raw_request(dev, buf[0], buf, count, report_type,
- HID_REQ_SET_REPORT, (__u64)file, false);
+ HID_REQ_SET_REPORT, (unsigned long)file, false);
out_free:
kfree(buf);
@@ -228,7 +228,7 @@ static ssize_t hidraw_get_report(struct file *file, char __user *buffer, size_t
}
ret = __hid_hw_raw_request(dev, report_number, buf, count, report_type,
- HID_REQ_GET_REPORT, (__u64)file, false);
+ HID_REQ_GET_REPORT, (unsigned long)file, false);
if (ret < 0)
goto out_free;
--
2.43.0
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next reply other threads:[~2024-07-01 8:51 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-01 8:51 Stephen Rothwell [this message]
2024-07-01 12:43 ` linux-next: build failure after merge of the hid tree Benjamin Tissoires
-- strict thread matches above, loose matches on Subject: below --
2026-03-02 13:56 Mark Brown
2026-03-02 15:58 ` Benjamin Tissoires
2026-03-02 17:52 ` Denis Benato
2025-02-09 23:43 Stephen Rothwell
2025-02-10 22:07 ` Jiri Kosina
2025-02-11 3:15 ` Kate Hsuan
2025-01-10 6:52 Stephen Rothwell
2024-06-20 13:55 Mark Brown
2024-05-07 1:06 Stephen Rothwell
2024-05-07 7:22 ` Kenny Levinsen
2024-04-11 0:51 Stephen Rothwell
2024-04-11 7:17 ` Benjamin Tissoires
2024-02-28 3:56 Stephen Rothwell
2022-07-25 0:40 Stephen Rothwell
2022-07-25 9:42 ` Jiri Kosina
2022-07-27 1:11 ` Stephen Rothwell
2021-12-03 7:01 Stephen Rothwell
2021-12-03 8:09 ` Greg Kroah-Hartman
2021-05-27 5:26 Stephen Rothwell
2021-05-27 8:14 ` Jiri Kosina
2021-05-27 8:25 ` Hans de Goede
2021-05-27 13:22 ` Naresh Kamboju
2021-05-27 13:42 ` Jiri Kosina
2019-10-04 0:28 Stephen Rothwell
2019-10-04 6:55 ` Hans de Goede
2016-12-11 23:59 Stephen Rothwell
2016-12-12 8:50 ` Jiri Kosina
2012-06-29 2:47 Stephen Rothwell
2012-06-29 13:03 ` Jiri Kosina
2011-12-19 1:34 Stephen Rothwell
2011-12-19 8:21 ` Jiri Kosina
2011-11-29 1:00 Stephen Rothwell
2011-11-29 1:30 ` Jeremy Fitzhardinge
2011-06-08 3:03 Stephen Rothwell
2011-06-08 7:26 ` Stefan Kriwanek
2011-06-08 7:50 ` Jiri Kosina
2011-04-07 1:06 Stephen Rothwell
2011-04-07 13:00 ` Alan Ott
2011-04-08 23:54 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240701185104.52c159c1@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=benjamin.tissoires@redhat$(echo .)com \
--cc=bentiss@kernel$(echo .)org \
--cc=jikos@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox