From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Lee Jones <lee@kernel•org>
Cc: Christian Marangi <ansuelsmth@gmail•com>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Linux Next Mailing List <linux-next@vger•kernel.org>
Subject: linux-next: build failure after merge of the leds-lj tree
Date: Fri, 12 Jul 2024 14:48:31 +1000 [thread overview]
Message-ID: <20240712144831.269b1bc6@canb.auug.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 3312 bytes --]
Hi all,
After merging the leds-lj tree, today's linux-next build (x86_64
allmodconfig) failed like this:
In file included from drivers/leds/leds-lp5569.c:11:
drivers/leds/leds-lp5569.c: In function 'lp5569_post_init_device':
drivers/leds/leds-lp5569.c:204:52: error: passing argument 3 of 'lp55xx_read' from incompatible pointer type [-Werror=incompatible-pointer-types]
204 | chip, LP5569_REG_STATUS, &val);
| ^~~~
| |
| int *
include/linux/iopoll.h:46:28: note: in definition of macro 'read_poll_timeout'
46 | (val) = op(args); \
| ^~~~
In file included from drivers/leds/leds-lp5569.c:20:
drivers/leds/leds-lp55xx-common.h:229:62: note: expected 'u8 *' {aka 'unsigned char *'} but argument is of type 'int *'
229 | extern int lp55xx_read(struct lp55xx_chip *chip, u8 reg, u8 *val);
| ~~~~^~~
drivers/leds/leds-lp5569.c:204:52: error: passing argument 3 of 'lp55xx_read' from incompatible pointer type [-Werror=incompatible-pointer-types]
204 | chip, LP5569_REG_STATUS, &val);
| ^~~~
| |
| int *
include/linux/iopoll.h:51:36: note: in definition of macro 'read_poll_timeout'
51 | (val) = op(args); \
| ^~~~
drivers/leds/leds-lp55xx-common.h:229:62: note: expected 'u8 *' {aka 'unsigned char *'} but argument is of type 'int *'
229 | extern int lp55xx_read(struct lp55xx_chip *chip, u8 reg, u8 *val);
| ~~~~^~~
cc1: all warnings being treated as errors
Caused by commit
d9cc80b1c9b4 ("leds: leds-lp5569: Enable chip after chip configuration")
I have applied the folloing patch for today.
From: Stephen Rothwell <sfr@canb•auug.org.au>
Date: Fri, 12 Jul 2024 14:40:23 +1000
Subject: [PATCH] fixup for "leds: leds-lp5569: Enable chip after chip configuration"
Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
---
drivers/leds/leds-lp5569.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/leds/leds-lp5569.c b/drivers/leds/leds-lp5569.c
index 52fb83f35bb7..623030f2f5ac 100644
--- a/drivers/leds/leds-lp5569.c
+++ b/drivers/leds/leds-lp5569.c
@@ -173,6 +173,7 @@ static int lp5569_post_init_device(struct lp55xx_chip *chip)
{
int ret;
int val;
+ u8 u8val;
val = LP5569_DEFAULT_CONFIG;
val |= FIELD_PREP(LP5569_CP_MODE_MASK, chip->pdata->charge_pump_mode);
@@ -201,7 +202,7 @@ static int lp5569_post_init_device(struct lp55xx_chip *chip)
read_poll_timeout(lp55xx_read, ret, !(val & LP5569_STARTUP_BUSY),
LP5569_STARTUP_SLEEP, LP5569_STARTUP_SLEEP * 10, false,
- chip, LP5569_REG_STATUS, &val);
+ chip, LP5569_REG_STATUS, &u8val);
return lp5569_init_program_engine(chip);
}
--
2.43.0
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next reply other threads:[~2024-07-12 4:58 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-12 4:48 Stephen Rothwell [this message]
2024-07-12 7:31 ` linux-next: build failure after merge of the leds-lj tree Lee Jones
2024-07-12 7:48 ` Christian Marangi
2024-07-12 8:21 ` Lee Jones
-- strict thread matches above, loose matches on Subject: below --
2026-03-06 13:47 Mark Brown
2026-01-09 1:45 Stephen Rothwell
2026-01-09 9:41 ` Lee Jones
2026-01-19 18:56 ` Mark Brown
2026-01-20 8:46 ` Lee Jones
2026-01-26 22:00 ` Mark Brown
2026-02-02 14:56 ` Mark Brown
2026-02-03 18:26 ` Mark Brown
2026-02-04 9:21 ` Lee Jones
2025-03-21 4:52 Stephen Rothwell
2025-03-21 9:24 ` Lee Jones
2025-02-21 3:42 Stephen Rothwell
2024-07-10 6:34 Stephen Rothwell
2024-07-10 7:16 ` Lee Jones
2024-01-29 2:10 Stephen Rothwell
2024-01-31 8:56 ` Lee Jones
[not found] <20230809131733.67238c8a@canb.auug.org.au>
2023-08-09 12:53 ` Marek Vasut
2023-03-20 0:48 Stephen Rothwell
2023-03-20 1:00 ` ChiYuan Huang
2023-03-21 23:55 ` Stephen Rothwell
2023-03-22 15:28 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240712144831.269b1bc6@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=ansuelsmth@gmail$(echo .)com \
--cc=lee@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox