From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Andrew Morton <akpm@linux-foundation•org>
Cc: Jani Nikula <jani.nikula@intel•com>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Linux Next Mailing List <linux-next@vger•kernel.org>
Subject: linux-next: build failure after merge of the mm tree
Date: Thu, 15 Aug 2024 09:57:34 +1000 [thread overview]
Message-ID: <20240815095734.751c6ec5@canb.auug.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 8614 bytes --]
Hi all,
After merging the mm tree, today's linux-next build (x86_64 allmodconfig)
failed like this:
drivers/nvme/host/fault_inject.c: In function 'nvme_fault_inject_init':
drivers/nvme/host/fault_inject.c:29:18: error: implicit declaration of function 'debugfs_create_dir'; did you mean 'kernfs_create_dir'? [-Werror=implicit-function-declaration]
29 | parent = debugfs_create_dir(dev_name, NULL);
| ^~~~~~~~~~~~~~~~~~
| kernfs_create_dir
drivers/nvme/host/fault_inject.c:29:16: error: assignment to 'struct dentry *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
29 | parent = debugfs_create_dir(dev_name, NULL);
| ^
drivers/nvme/host/fault_inject.c:39:17: error: implicit declaration of function 'debugfs_remove_recursive' [-Werror=implicit-function-declaration]
39 | debugfs_remove_recursive(parent);
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/nvme/host/fault_inject.c:47:9: error: implicit declaration of function 'debugfs_create_x16' [-Werror=implicit-function-declaration]
47 | debugfs_create_x16("status", 0600, dir, &fault_inj->status);
| ^~~~~~~~~~~~~~~~~~
drivers/nvme/host/fault_inject.c:48:9: error: implicit declaration of function 'debugfs_create_bool'; did you mean 'kernfs_create_root'? [-Werror=implicit-function-declaration]
48 | debugfs_create_bool("dont_retry", 0600, dir, &fault_inj->dont_retry);
| ^~~~~~~~~~~~~~~~~~~
| kernfs_create_root
cc1: all warnings being treated as errors
drivers/iommu/iommufd/selftest.c: In function 'iommufd_test_init':
drivers/iommu/iommufd/selftest.c:1562:9: error: implicit declaration of function 'debugfs_remove_recursive' [-Werror=implicit-function-declaration]
1562 | debugfs_remove_recursive(dbgfs_root);
| ^~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
kernel/futex/core.c: In function 'fail_futex_debugfs':
kernel/futex/core.c:98:9: error: implicit declaration of function 'debugfs_create_bool'; did you mean 'kernfs_create_root'? [-Werror=implicit-function-declaration]
98 | debugfs_create_bool("ignore-private", mode, dir,
| ^~~~~~~~~~~~~~~~~~~
| kernfs_create_root
cc1: all warnings being treated as errors
mm/fail_page_alloc.c: In function 'fail_page_alloc_debugfs':
mm/fail_page_alloc.c:57:9: error: implicit declaration of function 'debugfs_create_bool'; did you mean 'kernfs_create_root'? [-Werror=implicit-function-declaration]
57 | debugfs_create_bool("ignore-gfp-wait", mode, dir,
| ^~~~~~~~~~~~~~~~~~~
| kernfs_create_root
mm/fail_page_alloc.c:61:9: error: implicit declaration of function 'debugfs_create_u32' [-Werror=implicit-function-declaration]
61 | debugfs_create_u32("min-order", mode, dir, &fail_page_alloc.min_order);
| ^~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
mm/failslab.c: In function 'failslab_debugfs_init':
mm/failslab.c:65:9: error: implicit declaration of function 'debugfs_create_bool'; did you mean 'kernfs_create_root'? [-Werror=implicit-function-declaration]
65 | debugfs_create_bool("ignore-gfp-wait", mode, dir,
| ^~~~~~~~~~~~~~~~~~~
| kernfs_create_root
cc1: all warnings being treated as errors
lib/fault-inject.c: In function 'debugfs_create_ul':
lib/fault-inject.c:186:9: error: implicit declaration of function 'debugfs_create_file'; did you mean 'debugfs_create_ul'? [-Werror=implicit-function-declaration]
186 | debugfs_create_file(name, mode, parent, value, &fops_ul);
| ^~~~~~~~~~~~~~~~~~~
| debugfs_create_ul
lib/fault-inject.c: In function 'fault_create_debugfs_attr':
lib/fault-inject.c:217:15: error: implicit declaration of function 'debugfs_create_dir'; did you mean 'debugfs_create_ul'? [-Werror=implicit-function-declaration]
217 | dir = debugfs_create_dir(name, parent);
| ^~~~~~~~~~~~~~~~~~
| debugfs_create_ul
lib/fault-inject.c:217:13: error: assignment to 'struct dentry *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
217 | dir = debugfs_create_dir(name, parent);
| ^
lib/fault-inject.c:223:9: error: implicit declaration of function 'debugfs_create_atomic_t'; did you mean 'debugfs_create_ul'? [-Werror=implicit-function-declaration]
223 | debugfs_create_atomic_t("times", mode, dir, &attr->times);
| ^~~~~~~~~~~~~~~~~~~~~~~
| debugfs_create_ul
lib/fault-inject.c:226:9: error: implicit declaration of function 'debugfs_create_u32'; did you mean 'debugfs_create_ul'? [-Werror=implicit-function-declaration]
226 | debugfs_create_u32("verbose_ratelimit_interval_ms", mode, dir,
| ^~~~~~~~~~~~~~~~~~
| debugfs_create_ul
lib/fault-inject.c:230:9: error: implicit declaration of function 'debugfs_create_bool'; did you mean 'debugfs_create_ul'? [-Werror=implicit-function-declaration]
230 | debugfs_create_bool("task-filter", mode, dir, &attr->task_filter);
| ^~~~~~~~~~~~~~~~~~~
| debugfs_create_ul
lib/fault-inject.c:235:9: error: implicit declaration of function 'debugfs_create_xul'; did you mean 'debugfs_create_ul'? [-Werror=implicit-function-declaration]
235 | debugfs_create_xul("require-start", mode, dir, &attr->require_start);
| ^~~~~~~~~~~~~~~~~~
| debugfs_create_ul
cc1: all warnings being treated as errors
Caused by commit
2771559a5531 ("fault-inject: improve build for CONFIG_FAULT_INJECTION=n")
This is just whack-a-mole ... :-(
I have applied the following patch for today.
From: Stephen Rothwell <sfr@canb•auug.org.au>
Date: Thu, 15 Aug 2024 09:47:30 +1000
Subject: [PATCH] fix up for "fault-inject: improve build for CONFIG_FAULT_INJECTION=n"
Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
---
drivers/iommu/iommufd/selftest.c | 1 +
drivers/nvme/host/fault_inject.c | 1 +
kernel/futex/core.c | 1 +
lib/fault-inject.c | 1 +
mm/fail_page_alloc.c | 1 +
mm/failslab.c | 1 +
6 files changed, 6 insertions(+)
diff --git a/drivers/iommu/iommufd/selftest.c b/drivers/iommu/iommufd/selftest.c
index f95e32e29133..d9024c00c6c3 100644
--- a/drivers/iommu/iommufd/selftest.c
+++ b/drivers/iommu/iommufd/selftest.c
@@ -8,6 +8,7 @@
#include <linux/xarray.h>
#include <linux/file.h>
#include <linux/anon_inodes.h>
+#include <linux/debugfs.h>
#include <linux/fault-inject.h>
#include <linux/platform_device.h>
#include <uapi/linux/iommufd.h>
diff --git a/drivers/nvme/host/fault_inject.c b/drivers/nvme/host/fault_inject.c
index 1d1b6441a339..105d6cb41c72 100644
--- a/drivers/nvme/host/fault_inject.c
+++ b/drivers/nvme/host/fault_inject.c
@@ -6,6 +6,7 @@
*/
#include <linux/moduleparam.h>
+#include <linux/debugfs.h>
#include "nvme.h"
static DECLARE_FAULT_ATTR(fail_default_attr);
diff --git a/kernel/futex/core.c b/kernel/futex/core.c
index 06a1f091be81..f7cddf321593 100644
--- a/kernel/futex/core.c
+++ b/kernel/futex/core.c
@@ -36,6 +36,7 @@
#include <linux/pagemap.h>
#include <linux/plist.h>
#include <linux/memblock.h>
+#include <linux/debugfs.h>
#include <linux/fault-inject.h>
#include <linux/slab.h>
diff --git a/lib/fault-inject.c b/lib/fault-inject.c
index d608f9b48c10..d5853defe77a 100644
--- a/lib/fault-inject.c
+++ b/lib/fault-inject.c
@@ -9,6 +9,7 @@
#include <linux/export.h>
#include <linux/interrupt.h>
#include <linux/stacktrace.h>
+#include <linux/debugfs.h>
#include <linux/fault-inject.h>
/*
diff --git a/mm/fail_page_alloc.c b/mm/fail_page_alloc.c
index 532851ce5132..4c7aa18450c9 100644
--- a/mm/fail_page_alloc.c
+++ b/mm/fail_page_alloc.c
@@ -1,4 +1,5 @@
// SPDX-License-Identifier: GPL-2.0
+#include <linux/debugfs.h>
#include <linux/fault-inject.h>
#include <linux/error-injection.h>
#include <linux/mm.h>
diff --git a/mm/failslab.c b/mm/failslab.c
index af16c2ed578f..4b02bc8b420e 100644
--- a/mm/failslab.c
+++ b/mm/failslab.c
@@ -1,4 +1,5 @@
// SPDX-License-Identifier: GPL-2.0
+#include <linux/debugfs.h>
#include <linux/fault-inject.h>
#include <linux/error-injection.h>
#include <linux/slab.h>
--
2.43.0
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next reply other threads:[~2024-08-14 23:57 UTC|newest]
Thread overview: 189+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 23:57 Stephen Rothwell [this message]
2024-08-15 0:06 ` linux-next: build failure after merge of the mm tree Stephen Rothwell
2024-08-15 22:57 ` Andrew Morton
2024-08-15 0:08 ` Andrew Morton
2024-08-15 0:25 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2025-03-12 0:36 Stephen Rothwell
2025-03-12 2:14 ` Wei Yang
2025-03-12 2:30 ` Stephen Rothwell
2025-03-12 13:10 ` Wei Yang
2025-03-12 15:24 ` Andrew Morton
2025-03-11 10:26 Stephen Rothwell
2025-02-26 5:12 Stephen Rothwell
2025-02-19 4:52 Stephen Rothwell
2025-02-16 23:14 Stephen Rothwell
2025-02-16 23:22 ` Suren Baghdasaryan
2025-02-17 5:45 ` Suren Baghdasaryan
2025-01-09 4:59 Stephen Rothwell
2025-01-09 5:01 ` Stephen Rothwell
2025-01-09 5:32 ` Andrew Morton
2025-01-09 11:00 ` Alistair Popple
2025-01-08 23:06 Stephen Rothwell
2025-01-09 4:24 ` Alistair Popple
2024-12-19 23:39 Stephen Rothwell
2024-12-09 6:08 Stephen Rothwell
2024-12-10 2:25 ` Andrew Morton
2024-12-10 2:59 ` Suren Baghdasaryan
2024-12-10 3:37 ` SeongJae Park
2024-12-10 5:00 ` Stephen Rothwell
2024-12-10 5:30 ` Andrew Morton
2024-12-09 4:28 Stephen Rothwell
2024-12-09 11:14 ` Lorenzo Stoakes
2024-12-09 0:01 Stephen Rothwell
2024-10-27 23:36 Stephen Rothwell
2024-10-28 1:00 ` Andrew Morton
2024-08-14 23:38 Stephen Rothwell
2024-08-15 7:42 ` Uros Bizjak
2024-08-15 12:28 ` Uros Bizjak
2024-08-16 1:29 ` Stephen Rothwell
2024-08-16 6:45 ` Uros Bizjak
2024-08-11 23:30 Stephen Rothwell
2024-08-12 22:14 ` Kaiyang Zhao
2024-07-23 22:49 Stephen Rothwell
2024-07-24 5:31 ` Lorenzo Stoakes
2024-07-24 5:57 ` Andrew Morton
2024-07-09 23:32 Stephen Rothwell
2024-07-09 8:40 Stephen Rothwell
2024-07-09 8:45 ` Stephen Rothwell
2024-06-19 11:31 Mark Brown
2024-04-30 0:38 Stephen Rothwell
2024-04-30 2:23 ` Lance Yang
2024-04-23 0:22 Stephen Rothwell
2024-04-12 6:39 Stephen Rothwell
2024-04-11 23:14 Stephen Rothwell
2024-04-07 23:15 Stephen Rothwell
2024-04-08 1:44 ` Barry Song
2024-04-05 2:55 Stephen Rothwell
2024-03-28 4:34 Stephen Rothwell
2024-03-05 4:26 Stephen Rothwell
2024-03-05 6:39 ` Qi Zheng
2024-02-14 3:57 Stephen Rothwell
2024-02-14 15:19 ` Andrew Morton
2024-02-15 3:47 ` Stephen Rothwell
2024-02-07 6:17 Stephen Rothwell
2024-02-01 2:57 Stephen Rothwell
2024-02-01 8:35 ` Marco Elver
2024-01-25 3:29 Stephen Rothwell
2024-01-25 14:29 ` Baoquan He
2024-01-25 18:03 ` Stephen Rothwell
2024-01-24 23:23 Stephen Rothwell
2024-01-24 23:52 ` Suren Baghdasaryan
2024-01-25 2:40 ` Baoquan He
2024-01-23 23:05 Stephen Rothwell
2024-01-23 23:14 ` Suren Baghdasaryan
2023-12-21 7:38 Stephen Rothwell
2023-12-21 7:45 ` Changbin Du
2023-11-28 21:45 Stephen Rothwell
2023-11-28 22:45 ` Andrew Morton
2023-11-29 8:17 ` Dmitry Rokosov
2023-11-30 22:12 ` Stephen Rothwell
2023-11-27 3:44 Stephen Rothwell
2023-12-22 0:16 ` Stephen Rothwell
2023-12-22 6:26 ` Andrew Morton
2023-11-27 2:28 Stephen Rothwell
2023-11-27 3:48 ` Stephen Rothwell
2023-11-30 22:04 ` Stephen Rothwell
2023-11-30 22:32 ` Andrew Morton
2023-11-30 22:39 ` Michael Ellerman
2023-11-30 22:52 ` Andrew Morton
2023-12-01 3:12 ` Michael Ellerman
2023-12-07 12:38 ` Michael Ellerman
2023-10-03 22:50 Stephen Rothwell
2023-09-27 23:22 Stephen Rothwell
2023-09-28 6:47 ` Arnd Bergmann
2023-09-25 23:18 Stephen Rothwell
2023-08-22 22:52 Stephen Rothwell
2023-08-21 23:55 Stephen Rothwell
2023-08-22 1:11 ` Matthew Wilcox
2023-08-22 1:22 ` Stephen Rothwell
2023-08-22 1:34 ` Matthew Wilcox
2023-08-22 4:00 ` Darrick J. Wong
2023-08-22 20:20 ` Matthew Wilcox
2023-08-22 7:12 ` Michael Ellerman
2023-08-08 4:40 Stephen Rothwell
2023-08-08 15:20 ` Eric DeVolder
2023-08-11 17:16 ` Eric DeVolder
2023-07-26 5:14 Stephen Rothwell
2023-07-26 13:22 ` Kuan-Ying Lee (李冠穎)
2023-07-26 4:53 Stephen Rothwell
2023-07-26 5:22 ` Aneesh Kumar K.V
2023-07-26 6:51 ` Stephen Rothwell
2023-07-19 4:32 Stephen Rothwell
2023-07-19 5:55 ` Alistair Popple
2023-07-18 0:02 Stephen Rothwell
2023-07-18 13:43 ` Andy Shevchenko
2023-07-18 17:34 ` Andrew Morton
2023-07-18 21:07 ` Andy Shevchenko
2023-07-17 23:40 Stephen Rothwell
2023-07-04 2:23 Stephen Rothwell
2023-07-04 2:32 ` Linus Torvalds
2023-07-04 5:51 ` Suren Baghdasaryan
2023-06-13 6:21 Stephen Rothwell
2023-06-13 15:58 ` Catalin Marinas
2023-05-19 2:43 Stephen Rothwell
2023-05-19 8:19 ` Arnd Bergmann
2023-05-17 23:59 Stephen Rothwell
2023-03-06 2:54 Stephen Rothwell
2023-03-06 3:13 ` Andrew Morton
2023-03-06 0:52 Stephen Rothwell
2023-03-06 21:58 ` Stephen Rothwell
2023-02-07 4:37 Stephen Rothwell
2023-02-07 12:17 ` Jason Gunthorpe
2023-02-07 14:25 ` David Howells
2023-02-08 2:41 ` Stephen Rothwell
2023-01-30 5:14 Stephen Rothwell
2023-01-30 8:09 ` Christian Brauner
2023-02-26 22:18 ` Stephen Rothwell
2023-02-27 10:36 ` Christian Brauner
2023-01-27 6:36 Stephen Rothwell
2023-01-27 6:16 Stephen Rothwell
2023-01-27 5:59 Stephen Rothwell
2023-01-27 13:11 ` Jan Kara
2023-01-31 21:47 ` Stephen Rothwell
2023-02-24 4:40 ` Stephen Rothwell
2023-02-24 6:01 ` Linus Torvalds
2023-02-24 20:36 ` Stephen Rothwell
2023-01-25 3:05 Stephen Rothwell
2022-12-16 1:26 Stephen Rothwell
2022-12-16 3:04 ` Andrew Morton
2022-12-16 0:21 Stephen Rothwell
2022-12-16 0:35 ` Andrew Morton
2022-12-16 1:03 ` Masami Hiramatsu
2022-11-22 6:53 Stephen Rothwell
2022-11-22 10:31 ` David Hildenbrand
2022-11-03 5:02 Stephen Rothwell
2022-11-02 3:55 Stephen Rothwell
2022-11-02 21:26 ` Andrew Morton
2022-10-18 1:24 Stephen Rothwell
2022-09-23 8:12 Stephen Rothwell
2022-09-23 8:15 ` David Hildenbrand
2022-09-23 7:55 Stephen Rothwell
2022-09-23 9:50 ` Michael Walle
2022-09-23 11:01 ` Naoya Horiguchi
2022-09-15 7:07 Stephen Rothwell
2022-09-15 16:37 ` Mike Kravetz
2022-09-15 20:06 ` Andrew Morton
2022-09-06 11:03 Stephen Rothwell
2022-09-06 12:05 ` Rob Clark
2022-09-06 18:05 ` Stephen Rothwell
2022-08-26 7:10 Stephen Rothwell
2022-08-26 7:32 ` Michal Hocko
2022-07-08 9:44 Stephen Rothwell
2022-07-08 15:17 ` Darrick J. Wong
2022-07-10 22:28 ` Stephen Rothwell
2022-05-12 9:38 Stephen Rothwell
2022-05-12 10:13 ` Baolin Wang
2022-05-12 11:07 ` Catalin Marinas
2022-05-12 11:13 ` Baolin Wang
2022-05-12 13:28 ` Catalin Marinas
2022-05-12 19:10 ` Andrew Morton
2022-05-13 7:18 ` Stephen Rothwell
2022-05-11 8:15 Stephen Rothwell
2022-05-11 8:27 ` Baolin Wang
2022-05-11 8:42 ` Baolin Wang
2022-05-11 23:28 ` Stephen Rothwell
2022-05-10 11:25 Stephen Rothwell
2022-05-05 21:37 Stephen Rothwell
2022-05-02 10:49 Stephen Rothwell
2022-05-02 11:19 ` Matthew Wilcox
2022-05-03 6:45 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240815095734.751c6ec5@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=akpm@linux-foundation$(echo .)org \
--cc=jani.nikula@intel$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox