From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Al Viro <viro@zeniv•linux.org.uk>
Cc: Linux Next Mailing List <linux-next@vger•kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Christian Brauner <brauner@kernel•org>
Subject: linux-next: simple boot test failure (Was: linux-next: Tree for Oct 9)
Date: Wed, 9 Oct 2024 23:22:16 +1100 [thread overview]
Message-ID: <20241009232216.6f0a28e5@canb.auug.org.au> (raw)
In-Reply-To: <20241009182016.61736424@canb.auug.org.au>
[-- Attachment #1: Type: text/plain, Size: 1312 bytes --]
Hi all,
On Wed, 9 Oct 2024 18:20:16 +1100 Stephen Rothwell <sfr@canb•auug.org.au> wrote:
>
> News: this release fails my very simple qemu boot test. It looks normal
> up to user mode and I even get a login prompt, but when I log in I get
> dumped back to the login prompt - presumably the shell is failing to run.
Bisected to
218a562f273bec7731af4e713df72d2c8c8816e8 is the first bad commit
commit 218a562f273bec7731af4e713df72d2c8c8816e8
Author: Al Viro <viro@zeniv•linux.org.uk>
Date: Mon Oct 7 18:43:57 2024 +0100
make __set_open_fd() set cloexec state as well
->close_on_exec[] state is maintained only for opened descriptors;
as the result, anything that marks a descriptor opened has to
set its cloexec state explicitly.
As the result, all calls of __set_open_fd() are followed by
__set_close_on_exec(); might as well fold it into __set_open_fd()
so that cloexec state is defined as soon as the descriptor is
marked opened.
Signed-off-by: Al Viro <viro@zeniv•linux.org.uk>
Link: https://lore.kernel.org/r/20241007174358.396114-10-viro@zeniv.linux.org.uk
Signed-off-by: Christian Brauner <brauner@kernel•org>
And reverting that commit from today's linux-next fixes my problem.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-10-09 12:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 7:20 linux-next: Tree for Oct 9 Stephen Rothwell
2024-10-09 9:04 ` Aithal, Srikanth
2024-10-09 9:14 ` Aithal, Srikanth
2024-10-09 12:22 ` Stephen Rothwell [this message]
2024-10-10 5:21 ` linux-next: simple boot test failure (Was: linux-next: Tree for Oct 9) Aithal, Srikanth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241009232216.6f0a28e5@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=brauner@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=viro@zeniv$(echo .)linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox