From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Kent Overstreet <kent.overstreet@linux•dev>
Cc: "Andrew Morton" <akpm@linux-foundation•org>,
Michal Hocko <mhocko@suse•com>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Linux Next Mailing List <linux-next@vger•kernel.org>
Subject: Re: linux-next: build failure after merge of the bcachefs tree
Date: Thu, 10 Oct 2024 16:50:18 +1100 [thread overview]
Message-ID: <20241010165018.47b3fe1d@canb.auug.org.au> (raw)
In-Reply-To: <20240927104628.2ca6ad07@canb.auug.org.au>
[-- Attachment #1: Type: text/plain, Size: 6158 bytes --]
Hi all,
On Fri, 27 Sep 2024 10:46:28 +1000 Stephen Rothwell <sfr@canb•auug.org.au> wrote:
>
> After merging the fs-next tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> In file included from fs/bcachefs/str_hash.h:5,
> from fs/bcachefs/xattr.h:5,
> from fs/bcachefs/acl.c:6:
> fs/bcachefs/acl.c: In function 'bch2_acl_from_disk':
> fs/bcachefs/btree_iter.h:896:44: error: 'PF_MEMALLOC_NORECLAIM' undeclared (first use in this function); did you mean 'PF_MEMALLOC_NOIO'?
> 896 | typeof(_do) _p = memalloc_flags_do(PF_MEMALLOC_NORECLAIM|PF_MEMALLOC_NOWARN, _do);\
> | ^~~~~~~~~~~~~~~~~~~~~
> fs/bcachefs/btree_iter.h:878:53: note: in definition of macro 'memalloc_flags_do'
> 878 | unsigned _saved_flags = memalloc_flags_save(_flags); \
> | ^~~~~~
> fs/bcachefs/acl.c:139:15: note: in expansion of macro 'allocate_dropping_locks'
> 139 | acl = allocate_dropping_locks(trans, ret,
> | ^~~~~~~~~~~~~~~~~~~~~~~
> fs/bcachefs/btree_iter.h:896:44: note: each undeclared identifier is reported only once for each function it appears in
> 896 | typeof(_do) _p = memalloc_flags_do(PF_MEMALLOC_NORECLAIM|PF_MEMALLOC_NOWARN, _do);\
> | ^~~~~~~~~~~~~~~~~~~~~
> fs/bcachefs/btree_iter.h:878:53: note: in definition of macro 'memalloc_flags_do'
> 878 | unsigned _saved_flags = memalloc_flags_save(_flags); \
> | ^~~~~~
> fs/bcachefs/acl.c:139:15: note: in expansion of macro 'allocate_dropping_locks'
> 139 | acl = allocate_dropping_locks(trans, ret,
> | ^~~~~~~~~~~~~~~~~~~~~~~
> fs/bcachefs/btree_iter.h:896:66: error: 'PF_MEMALLOC_NOWARN' undeclared (first use in this function); did you mean 'PF_MEMALLOC_NOFS'?
> 896 | typeof(_do) _p = memalloc_flags_do(PF_MEMALLOC_NORECLAIM|PF_MEMALLOC_NOWARN, _do);\
> | ^~~~~~~~~~~~~~~~~~
> fs/bcachefs/btree_iter.h:878:53: note: in definition of macro 'memalloc_flags_do'
> 878 | unsigned _saved_flags = memalloc_flags_save(_flags); \
> | ^~~~~~
> fs/bcachefs/acl.c:139:15: note: in expansion of macro 'allocate_dropping_locks'
> 139 | acl = allocate_dropping_locks(trans, ret,
> | ^~~~~~~~~~~~~~~~~~~~~~~
> fs/bcachefs/acl.c: In function 'bch2_acl_chmod':
> fs/bcachefs/btree_iter.h:886:38: error: 'PF_MEMALLOC_NORECLAIM' undeclared (first use in this function); did you mean 'PF_MEMALLOC_NOIO'?
> 886 | int _ret = memalloc_flags_do(PF_MEMALLOC_NORECLAIM|PF_MEMALLOC_NOWARN, _do);\
> | ^~~~~~~~~~~~~~~~~~~~~
> fs/bcachefs/btree_iter.h:878:53: note: in definition of macro 'memalloc_flags_do'
> 878 | unsigned _saved_flags = memalloc_flags_save(_flags); \
> | ^~~~~~
> fs/bcachefs/acl.c:430:15: note: in expansion of macro 'allocate_dropping_locks_errcode'
> 430 | ret = allocate_dropping_locks_errcode(trans,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> fs/bcachefs/btree_iter.h:886:60: error: 'PF_MEMALLOC_NOWARN' undeclared (first use in this function); did you mean 'PF_MEMALLOC_NOFS'?
> 886 | int _ret = memalloc_flags_do(PF_MEMALLOC_NORECLAIM|PF_MEMALLOC_NOWARN, _do);\
> | ^~~~~~~~~~~~~~~~~~
> fs/bcachefs/btree_iter.h:878:53: note: in definition of macro 'memalloc_flags_do'
> 878 | unsigned _saved_flags = memalloc_flags_save(_flags); \
> | ^~~~~~
> fs/bcachefs/acl.c:430:15: note: in expansion of macro 'allocate_dropping_locks_errcode'
> 430 | ret = allocate_dropping_locks_errcode(trans,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> In file included from fs/bcachefs/btree_locking.h:13,
> from fs/bcachefs/btree_io.h:7,
> from fs/bcachefs/btree_cache.c:7:
> fs/bcachefs/btree_cache.c: In function 'bch2_btree_node_mem_alloc':
> fs/bcachefs/btree_cache.c:807:31: error: 'PF_MEMALLOC_NORECLAIM' undeclared (first use in this function); did you mean 'PF_MEMALLOC_NOIO'?
> 807 | if (memalloc_flags_do(PF_MEMALLOC_NORECLAIM,
> | ^~~~~~~~~~~~~~~~~~~~~
> fs/bcachefs/btree_iter.h:878:53: note: in definition of macro 'memalloc_flags_do'
> 878 | unsigned _saved_flags = memalloc_flags_save(_flags); \
> | ^~~~~~
> fs/bcachefs/btree_cache.c:807:31: note: each undeclared identifier is reported only once for each function it appears in
> 807 | if (memalloc_flags_do(PF_MEMALLOC_NORECLAIM,
> | ^~~~~~~~~~~~~~~~~~~~~
> fs/bcachefs/btree_iter.h:878:53: note: in definition of macro 'memalloc_flags_do'
> 878 | unsigned _saved_flags = memalloc_flags_save(_flags); \
> | ^~~~~~
>
> Caused by commit
>
> 87a3e08121cb ("bcachefs: Switch to memalloc_flags_do() for vmalloc allocations")
>
> from the bcachefs tree interacting with commit
>
> 0df1d8edfe8a ("Revert "mm: introduce PF_MEMALLOC_NORECLAIM, PF_MEMALLOC_NOWARN"")
>
> from the mm-hotfixes-unstable branch of the mm-hotfixes tree.
>
> I have reverted that mm-hotfixes commit for today.
The mm-hotixes commit is now in Linus' tree so tomorrow I will have to
revert it from the bcachefs tree merge (in stead of the fs-next tree
merge) unless someone comes up with something better.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-10-10 5:50 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-27 0:46 linux-next: build failure after merge of the bcachefs tree Stephen Rothwell
2024-10-10 5:50 ` Stephen Rothwell [this message]
2024-10-10 6:10 ` Kent Overstreet
2024-10-10 7:44 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2025-06-02 23:47 Stephen Rothwell
2025-05-21 23:14 Stephen Rothwell
2025-04-22 0:56 Stephen Rothwell
2025-03-26 2:28 Stephen Rothwell
2025-03-27 0:54 ` Stephen Rothwell
2025-03-27 3:01 ` Kent Overstreet
2024-11-10 22:32 Stephen Rothwell
2024-10-13 23:28 Stephen Rothwell
2024-10-14 6:17 ` Greg Kroah-Hartman
2024-10-14 6:18 ` Kent Overstreet
2024-09-11 1:44 Stephen Rothwell
2024-02-11 23:54 Stephen Rothwell
2024-02-14 0:16 ` Kees Cook
2024-02-14 0:29 ` Kent Overstreet
2024-02-14 0:39 ` Darrick J. Wong
2024-02-14 1:09 ` Kees Cook
2024-02-07 0:57 Stephen Rothwell
2024-02-08 22:46 ` Stephen Rothwell
2024-02-08 23:59 ` Kent Overstreet
2023-11-15 23:02 Stephen Rothwell
2023-11-12 22:30 Stephen Rothwell
2023-09-12 2:04 Stephen Rothwell
2023-09-12 2:47 ` Qi Zheng
2023-09-12 23:35 ` Stephen Rothwell
2023-09-13 1:10 ` Qi Zheng
2023-09-13 20:23 ` Andrew Morton
2023-09-13 22:31 ` Stephen Rothwell
2023-11-01 0:32 ` Stephen Rothwell
2023-11-01 0:53 ` Kent Overstreet
2023-11-01 1:14 ` Stephen Rothwell
2023-09-13 22:14 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241010165018.47b3fe1d@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=akpm@linux-foundation$(echo .)org \
--cc=kent.overstreet@linux$(echo .)dev \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mhocko@suse$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox