Subject: Re: linux-next: build failure after merge of the btrfs tree

From: David Sterba <[email-masked]>
Date: Tue, 29 Oct 2024 17:21:36 +0100

On Mon, Oct 28, 2024 at 09:03:30AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> On Thu, 24 Oct 2024 08:57:01 +1100 Stephen Rothwell <[email-masked]> wrote:
> >
> > After merging the btrfs tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> > 
> > fs/btrfs/super.c: In function 'btrfs_reconfigure_for_mount':
> > fs/btrfs/super.c:2011:56: error: suggest parentheses around '&&' within '||' [-Werror=parentheses]
> >  2011 |         if (!fc->oldapi || !(fc->sb_flags & SB_RDONLY) && (mnt->mnt_sb->s_flags & SB_RDONLY))
> >       |                            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > cc1: all warnings being treated as errors
> > 
> > Caused by commit
> > 
> >   4642e430c55b ("btrfs: fix mount failure due to remount races")
> > 
> > I have used the btrfs tree from next-20241023 for today.
> 
> I am still seeing this failure.

Sorry, will be fixed in the upcoming for-next snapshot branch.