public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Paolo Bonzini <pbonzini@redhat•com>
Cc: Sean Christopherson <seanjc@google•com>,
	KVM <kvm@vger•kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
	Linux Next Mailing List <linux-next@vger•kernel.org>
Subject: Re: linux-next: build warning after merge of the kvm tree
Date: Wed, 13 Nov 2024 17:29:02 +1100	[thread overview]
Message-ID: <20241113172902.7ada7d6e@canb.auug.org.au> (raw)
In-Reply-To: <20241028192945.2f1433fc@canb.auug.org.au>

[-- Attachment #1: Type: text/plain, Size: 3468 bytes --]

Hi all,

On Mon, 28 Oct 2024 19:29:45 +1100 Stephen Rothwell <sfr@canb•auug.org.au> wrote:
>
> After merging the kvm tree, today's linux-next build (htmldocs) produced
> this warning:
> 
> Documentation/virt/kvm/locking.rst:157: ERROR: Malformed table.
> 
> +-------------------------------------------------------------------------+
> | At the beginning::                                                      |
> |                                                                         |
> |       spte.W = 0                                                              |
> |       spte.Accessed = 1                                                       |
> +-------------------------------------+-----------------------------------+
> | CPU 0:                              | CPU 1:                            |
> +-------------------------------------+-----------------------------------+
> | In mmu_spte_update()::              |                                   |
> |                                     |                                   |
> |  old_spte = *spte;                  |                                   |
> |                                     |                                   |
> |                                     |                                   |
> |  /* 'if' condition is satisfied. */ |                                   |
> |  if (old_spte.Accessed == 1 &&      |                                   |
> |       old_spte.W == 0)              |                                   |
> |     spte = new_spte;                |                                   |
> +-------------------------------------+-----------------------------------+
> |                                     | on fast page fault path::         |
> |                                     |                                   |
> |                                     |    spte.W = 1                     |
> |                                     |                                   |
> |                                     | memory write on the spte::        |
> |                                     |                                   |
> |                                     |    spte.Dirty = 1                 |
> +-------------------------------------+-----------------------------------+
> |  ::                                 |                                   |
> |                                     |                                   |
> |   else                              |                                   |
> |     old_spte = xchg(spte, new_spte);|                                   |
> |   if (old_spte.Accessed &&          |                                   |
> |       !new_spte.Accessed)           |                                   |
> |     flush = true;                   |                                   |
> |   if (old_spte.Dirty &&             |                                   |
> |       !new_spte.Dirty)              |                                   |
> |     flush = true;                   |                                   |
> |     OOPS!!!                         |                                   |
> +-------------------------------------+-----------------------------------+
> 
> Introduced by commit
> 
>   5f6a3badbb74 ("KVM: x86/mmu: Mark page/folio accessed only when zapping leaf SPTEs")

I am still seeing this warning.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2024-11-13  6:29 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-28  8:29 linux-next: build warning after merge of the kvm tree Stephen Rothwell
2024-11-13  6:29 ` Stephen Rothwell [this message]
2024-11-13 13:58   ` Sean Christopherson
2024-11-13 14:00     ` Paolo Bonzini
  -- strict thread matches above, loose matches on Subject: below --
2025-04-09  3:13 Stephen Rothwell
2025-05-16  0:16 ` Stephen Rothwell
2024-09-23  3:45 Stephen Rothwell
2024-07-17  5:59 Stephen Rothwell
2024-07-30 10:11 ` Stephen Rothwell
2023-11-14  3:13 Stephen Rothwell
2023-11-14 12:50 ` Paolo Bonzini
2022-12-13  4:41 Stephen Rothwell
2022-12-13  5:11 ` Sean Christopherson
2022-06-27  8:19 Stephen Rothwell
2022-06-27  9:57 ` Bagas Sanjaya
2022-08-09  6:41 ` Stephen Rothwell
2022-01-10  8:58 Stephen Rothwell
2022-01-11  2:55 ` Wang, Wei W
2022-01-20  3:36   ` Stephen Rothwell
2022-01-20  5:52     ` Wang, Wei W
2021-04-22  8:53 Stephen Rothwell
2021-02-09  9:59 Stephen Rothwell
2021-02-09 10:01 ` Paolo Bonzini
2019-11-25  3:03 Stephen Rothwell
2013-01-10  2:34 Stephen Rothwell
2013-01-10  6:56 ` Gleb Natapov
2010-07-26  5:14 Stephen Rothwell
2010-05-27  4:53 Stephen Rothwell
2010-05-27 10:19 ` Roedel, Joerg
2010-05-27 10:49   ` Stephen Rothwell
2010-05-27 12:13   ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241113172902.7ada7d6e@canb.auug.org.au \
    --to=sfr@canb$(echo .)auug.org.au \
    --cc=kvm@vger$(echo .)kernel.org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=pbonzini@redhat$(echo .)com \
    --cc=seanjc@google$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox