From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Hans de Goede <hdegoede@redhat•com>, Mark Gross <markgross@kernel•org>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux•intel.com>,
"Joshua Grisham" <josh@joshuagrisham•com>,
"Linux Kernel Mailing List" <linux-kernel@vger•kernel.org>,
"Linux Next Mailing List" <linux-next@vger•kernel.org>
Subject: linux-next: build failure after merge of the drivers-x86 tree
Date: Thu, 6 Feb 2025 13:36:52 +1100 [thread overview]
Message-ID: <20250206133652.71bbf1d3@canb.auug.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 1497 bytes --]
Hi all,
After merging the drivers-x86 tree, today's linux-next build
(x86_64_allmodconfig) failed like this:
In file included from include/linux/kobject.h:20,
from include/linux/energy_model.h:7,
from include/linux/device.h:16,
from include/linux/acpi.h:14,
from drivers/platform/x86/samsung-galaxybook.c:14:
drivers/platform/x86/samsung-galaxybook.c: In function 'galaxybook_fw_attr_init':
drivers/platform/x86/samsung-galaxybook.c:1014:33: error: 'fw_attr' is a pointer; did you mean to use '->'?
1014 | sysfs_attr_init(&fw_attr.display_name);
| ^
include/linux/sysfs.h:55:10: note: in definition of macro 'sysfs_attr_init'
55 | (attr)->key = &__key; \
| ^~~~
drivers/platform/x86/samsung-galaxybook.c:1020:33: error: 'fw_attr' is a pointer; did you mean to use '->'?
1020 | sysfs_attr_init(&fw_attr.current_value);
| ^
include/linux/sysfs.h:55:10: note: in definition of macro 'sysfs_attr_init'
55 | (attr)->key = &__key; \
| ^~~~
Caused by commit
f97634611408 ("platform/x86: samsung-galaxybook: Add samsung-galaxybook driver")
I guess this was never built with CONFIG_DEBUG_LOCK_ALLOC set.
I have used the drivers-x86 tree from next-20250205 for today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next reply other threads:[~2025-02-06 2:37 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 2:36 Stephen Rothwell [this message]
2025-02-06 10:27 ` linux-next: build failure after merge of the drivers-x86 tree Ilpo Järvinen
2025-02-06 14:49 ` Joshua Grisham
2025-02-06 19:22 ` Ilpo Järvinen
-- strict thread matches above, loose matches on Subject: below --
2026-01-15 3:52 Stephen Rothwell
2026-01-15 3:54 ` Kees Cook
2026-01-15 9:53 ` Ilpo Järvinen
2025-05-15 6:46 Stephen Rothwell
2025-05-15 8:32 ` Ilpo Järvinen
2025-05-15 9:22 ` Ingo Molnar
2025-05-15 12:19 ` Stephen Rothwell
2025-05-15 12:57 ` Ingo Molnar
2021-08-20 5:00 Stephen Rothwell
2021-08-20 7:31 ` M D
2021-08-20 10:11 ` Hans de Goede
2021-07-28 16:48 Mark Brown
2021-07-28 17:01 ` Andy Shevchenko
2021-07-28 17:27 ` Kammela, Gayatri
2021-07-28 17:55 ` Hans de Goede
2021-07-28 17:59 ` Kammela, Gayatri
2019-10-15 2:00 Stephen Rothwell
2019-10-15 8:04 ` Andy Shevchenko
2019-10-15 11:42 ` Stephen Rothwell
2018-06-12 1:23 Stephen Rothwell
2018-06-12 3:28 ` dvhart
2018-06-12 5:18 ` Darren Hart
2015-06-05 10:13 Michael Ellerman
2015-06-08 4:52 ` Darren Hart
2015-06-04 8:13 Stephen Rothwell
2015-06-04 17:51 ` Radim Krčmář
2015-06-08 4:27 ` Darren Hart
2012-08-20 6:11 Stephen Rothwell
2012-08-20 6:44 ` AceLan Kao
2012-03-22 4:33 Stephen Rothwell
2012-03-21 5:52 Stephen Rothwell
2012-03-21 11:19 ` Matthew Garrett
2011-02-22 5:22 Stephen Rothwell
2011-02-22 6:26 ` Mattia Dongili
2011-02-22 11:46 ` Mattia Dongili
2011-02-22 14:34 ` Matthew Garrett
2011-02-22 22:22 ` Stephen Rothwell
2011-02-14 5:39 Stephen Rothwell
2011-02-14 22:42 ` Rafael J. Wysocki
2011-03-25 4:44 ` Stephen Rothwell
2011-02-08 3:45 Stephen Rothwell
2011-02-08 3:50 ` Matthew Garrett
2010-12-07 2:24 Stephen Rothwell
2010-10-05 4:11 Stephen Rothwell
2010-10-05 10:36 ` Ike Panhc
2010-10-06 10:45 ` Ike Panhc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250206133652.71bbf1d3@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=hdegoede@redhat$(echo .)com \
--cc=ilpo.jarvinen@linux$(echo .)intel.com \
--cc=josh@joshuagrisham$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=markgross@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox