From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Christian Brauner <brauner@kernel•org>,
Miklos Szeredi <miklos@szeredi•hu>
Cc: Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Linux Next Mailing List <linux-next@vger•kernel.org>,
Matt Johnston <matt@codeconstruct•com.au>,
Miklos Szeredi <mszeredi@redhat•com>, NeilBrown <neilb@suse•de>
Subject: linux-next: manual merge of the vfs-brauner tree with the fuse tree
Date: Fri, 28 Feb 2025 10:46:14 +1100 [thread overview]
Message-ID: <20250228104614.7e115517@canb.auug.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 1735 bytes --]
Hi all,
Today's linux-next merge of the vfs-brauner tree got a conflict in:
fs/fuse/dir.c
between commits:
712c587442f3 ("fuse: Return EPERM rather than ENOSYS from link()")
150b838b03e8 ("fuse: optmize missing FUSE_LINK support")
from the fuse tree and commit:
bac12649d4e5 ("fuse: return correct dentry for ->mkdir")
from the vfs-brauner tree.
I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging. You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.
--
Cheers,
Stephen Rothwell
diff --cc fs/fuse/dir.c
index 83c56ce6ad20,516de1ae24dd..000000000000
--- a/fs/fuse/dir.c
+++ b/fs/fuse/dir.c
@@@ -1134,19 -1137,13 +1140,19 @@@ static int fuse_link(struct dentry *ent
args.in_args[0].value = &inarg;
args.in_args[1].size = newent->d_name.len + 1;
args.in_args[1].value = newent->d_name.name;
- err = create_new_entry(&invalid_mnt_idmap, fm, &args, newdir, newent, inode->i_mode);
- if (!err)
+ de = create_new_entry(&invalid_mnt_idmap, fm, &args, newdir, newent, inode->i_mode);
+ if (!IS_ERR(de))
fuse_update_ctime_in_cache(inode);
- else if (err == -EINTR)
+ else if (PTR_ERR(de) == -EINTR)
fuse_invalidate_attr(inode);
- if (err == -ENOSYS)
++ if (PTR_ERR(de) == -ENOSYS)
+ fm->fc->no_link = 1;
+out:
+ if (fm->fc->no_link)
+ return -EPERM;
+
- return err;
+ return PTR_ERR(de);
}
static void fuse_fillattr(struct mnt_idmap *idmap, struct inode *inode,
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next reply other threads:[~2025-02-27 23:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-27 23:46 Stephen Rothwell [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-09-01 23:34 linux-next: manual merge of the vfs-brauner tree with the fuse tree Stephen Rothwell
2024-03-06 23:23 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250228104614.7e115517@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=brauner@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=matt@codeconstruct$(echo .)com.au \
--cc=miklos@szeredi$(echo .)hu \
--cc=mszeredi@redhat$(echo .)com \
--cc=neilb@suse$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox