Subject: linux-next: build failure after merge of the tty tree

From: Stephen Rothwell <[email-masked]>
Date: Mon, 24 Mar 2025 19:37:28 +1100

Hi all,

After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/tty/serial/fsl_lpuart.c: In function 'lpuart_poll_init':
drivers/tty/serial/fsl_lpuart.c:642:29: error: unused variable 'sport' [-Werror=unused-variable]
  642 |         struct lpuart_port *sport = container_of(port,
      |                             ^~~~~
drivers/tty/serial/fsl_lpuart.c: In function 'lpuart32_poll_init':
drivers/tty/serial/fsl_lpuart.c:696:29: error: unused variable 'sport' [-Werror=unused-variable]
  696 |         struct lpuart_port *sport = container_of(port, struct lpuart_port, port);
      |                             ^~~~~
cc1: all warnings being treated as errors

Caused by commit

  3cc16ae096f1 ("tty: serial: fsl_lpuart: use port struct directly to simply code")

I have applied the following patch for today:

From: Stephen Rothwell <[email-masked]>
Date: Mon, 24 Mar 2025 19:10:57 +1100
Subject: [PATCH] fix up for "tty: serial: fsl_lpuart: use port struct directly
 to simply code"

Signed-off-by: Stephen Rothwell <[email-masked]>
---
 drivers/tty/serial/fsl_lpuart.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
index 33eeefa6fa8f..4470966b826c 100644
--- a/drivers/tty/serial/fsl_lpuart.c
+++ b/drivers/tty/serial/fsl_lpuart.c
@@ -639,8 +639,6 @@ static void lpuart32_wait_bit_set(struct uart_port *port, unsigned int offset,
 
 static int lpuart_poll_init(struct uart_port *port)
 {
-	struct lpuart_port *sport = container_of(port,
-					struct lpuart_port, port);
 	unsigned long flags;
 	u8 fifo;
 
@@ -693,7 +691,6 @@ static int lpuart_poll_get_char(struct uart_port *port)
 static int lpuart32_poll_init(struct uart_port *port)
 {
 	unsigned long flags;
-	struct lpuart_port *sport = container_of(port, struct lpuart_port, port);
 	u32 fifo;
 
 	port->fifosize = 0;
-- 
2.45.2

-- 
Cheers,
Stephen Rothwell