From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Greg KH <greg@kroah•com>, Arnd Bergmann <arnd@arndb•de>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation•org>,
"Naman Jain" <namjain@linux•microsoft.com>,
"Thomas Weißschuh" <linux@weissschuh•net>,
"Linux Kernel Mailing List" <linux-kernel@vger•kernel.org>,
"Linux Next Mailing List" <linux-next@vger•kernel.org>
Subject: Re: linux-next: build failure after merge of the char-misc tree
Date: Mon, 5 May 2025 17:14:25 +1000 [thread overview]
Message-ID: <20250505171425.0d4169e2@canb.auug.org.au> (raw)
In-Reply-To: <20250505161215.58a03af0@canb.auug.org.au>
[-- Attachment #1: Type: text/plain, Size: 2391 bytes --]
Hi all,
On Mon, 5 May 2025 16:12:15 +1000 Stephen Rothwell <sfr@canb•auug.org.au> wrote:
>
> On Mon, 5 May 2025 16:08:31 +1000 Stephen Rothwell <sfr@canb•auug.org.au> wrote:
> >
> > After merging the char-misc tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > drivers/hv/vmbus_drv.c:1893:22: error: initialization of 'const struct bin_attribute * const*' from incompatible pointer type 'struct bin_attribute **' [-Wincompatible-pointer-types]
> > 1893 | .bin_attrs = vmbus_chan_bin_attrs,
> > | ^~~~~~~~~~~~~~~~~~~~
> > drivers/hv/vmbus_drv.c:1893:22: note: (near initialization for 'vmbus_chan_group.<anonymous>.bin_attrs')
> >
> > Caused by commit
> >
> > f31fe8165d36 ("uio_hv_generic: Fix sysfs creation path for ring buffer")
> >
> > interacting with commit
> >
> > 9bec944506fa ("sysfs: constify attribute_group::bin_attrs")
> >
> > from the driver-core tree.
> >
> > I have applied the following merge fixup for today.
>
> From: Stephen Rothwell <sfr@canb•auug.org.au>
> Date: Mon, 5 May 2025 15:56:12 +1000
> Subject: [PATCH] uio_hv_generic: constify bin_attribute definitions
>
> Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
> ---
> drivers/hv/vmbus_drv.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
> index e3d51a316316..857109bb99a0 100644
> --- a/drivers/hv/vmbus_drv.c
> +++ b/drivers/hv/vmbus_drv.c
> @@ -1815,7 +1815,7 @@ static int hv_mmap_ring_buffer_wrapper(struct file *filp, struct kobject *kobj,
> return channel->mmap_ring_buffer(channel, vma);
> }
>
> -static struct bin_attribute chan_attr_ring_buffer = {
> +static const struct bin_attribute chan_attr_ring_buffer = {
> .attr = {
> .name = "ring",
> .mode = 0600,
> @@ -1841,7 +1841,7 @@ static struct attribute *vmbus_chan_attrs[] = {
> NULL
> };
>
> -static struct bin_attribute *vmbus_chan_bin_attrs[] = {
> +static const struct bin_attribute *vmbus_chan_bin_attrs[] = {
> &chan_attr_ring_buffer,
> NULL
> };
> --
> 2.47.2
It occurred to me that the above patch could be applied directly to the
char-misc tree if vmbus_chan_bin_attrs was assigned to .bin_attrs_new
instead of .bin_attrs (later in the file), right?
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2025-05-05 7:14 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-05 6:08 linux-next: build failure after merge of the char-misc tree Stephen Rothwell
2025-05-05 6:12 ` Stephen Rothwell
2025-05-05 7:14 ` Stephen Rothwell [this message]
2025-05-05 7:39 ` Thomas Weißschuh
2025-05-05 8:28 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2026-01-21 16:10 Mark Brown
2026-01-21 23:08 ` Jeff Johnson
2025-07-03 11:20 回复: 回复: 回复: " Greg KH
2025-07-04 1:32 ` Lizhi Xu
2025-07-03 7:10 Stephen Rothwell
2025-07-03 8:30 ` Greg KH
2025-05-01 6:45 Stephen Rothwell
2025-05-01 7:26 ` Greg KH
2025-05-01 10:15 ` Thadeu Lima de Souza Cascardo
2025-05-01 14:20 ` Greg KH
2025-04-29 5:54 Stephen Rothwell
2025-04-29 10:58 ` Thadeu Lima de Souza Cascardo
2025-04-30 12:16 ` Thadeu Lima de Souza Cascardo
2025-04-30 14:09 ` Greg Kroah-Hartman
2023-06-26 4:25 Stephen Rothwell
2023-06-26 9:06 ` Greg KH
2022-05-20 9:46 Stephen Rothwell
2022-05-20 19:08 ` Greg KH
2022-06-12 17:23 ` Samuel Thibault
2022-02-25 20:40 broonie
2022-02-26 15:08 ` Greg KH
2022-03-01 5:14 ` Stephen Rothwell
2022-03-01 21:27 ` Greg KH
2021-10-27 4:48 Stephen Rothwell
2021-10-27 6:51 ` Greg KH
2020-07-27 8:08 Stephen Rothwell
2020-07-27 9:24 ` Greg KH
2020-07-27 9:28 ` Oded Gabbay
2020-07-27 10:05 ` Greg KH
2020-07-27 10:59 ` Oded Gabbay
2020-07-28 7:33 ` Stephen Rothwell
2020-07-28 7:53 ` Greg KH
2020-07-28 8:23 ` Stephen Rothwell
2020-07-28 17:17 ` Greg KH
2020-07-28 17:19 ` Greg KH
2020-07-29 9:55 ` Oded Gabbay
2020-05-04 1:46 Stephen Rothwell
2020-05-04 1:47 ` Stephen Rothwell
2020-05-04 7:14 ` Greg KH
[not found] ` <BYAPR02MB394115C2C80B1169D282A646B7A60@BYAPR02MB3941.namprd02.prod.outlook.com>
2020-05-04 7:31 ` Greg KH
2019-07-08 9:23 Stephen Rothwell
2019-07-12 0:44 ` Stephen Rothwell
2019-07-12 7:59 ` Greg KH
2017-04-12 5:18 Stephen Rothwell
2017-04-12 10:33 ` Greg KH
2017-03-20 2:44 Stephen Rothwell
2017-03-20 12:23 ` Arnd Bergmann
2017-03-21 0:18 ` Benjamin Herrenschmidt
2017-03-21 0:36 ` Cyril Bur
2017-03-21 2:58 ` Joel Stanley
2015-08-07 6:32 Stephen Rothwell
2015-05-27 5:52 Stephen Rothwell
2015-05-27 7:08 ` Winkler, Tomas
2015-05-27 12:36 ` Greg KH
2014-02-21 5:47 Stephen Rothwell
2014-02-26 6:47 ` Stephen Rothwell
2014-02-27 3:37 ` Greg KH
2014-02-27 5:48 ` Stephen Rothwell
2013-09-27 7:10 Stephen Rothwell
2013-09-28 1:04 ` Greg KH
2013-04-02 6:29 Stephen Rothwell
2013-04-02 6:49 ` Richard Weinberger
2013-03-26 4:18 Stephen Rothwell
2013-03-18 2:56 Stephen Rothwell
2013-03-18 8:58 ` Kurt Van Dijck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250505171425.0d4169e2@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=arnd@arndb$(echo .)de \
--cc=greg@kroah$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux@weissschuh$(echo .)net \
--cc=namjain@linux$(echo .)microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox