From: Stephen Rothwell <sfr@canb•auug.org.au>
To: John Garry <john.g.garry@oracle•com>
Cc: Alasdair G Kergon <agk@redhat•com>,
Mike Snitzer <snitzer@kernel•org>, Jens Axboe <axboe@kernel•dk>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Linux Next Mailing List <linux-next@vger•kernel.org>,
Mikulas Patocka <mpatocka@redhat•com>
Subject: Re: linux-next: manual merge of the device-mapper tree with the block tree
Date: Fri, 18 Jul 2025 18:56:42 +1000 [thread overview]
Message-ID: <20250718185642.0f2454c3@canb.auug.org.au> (raw)
In-Reply-To: <e08722e5-d5b8-41d5-92a2-f985a875c24b@oracle.com>
[-- Attachment #1: Type: text/plain, Size: 1545 bytes --]
Hi John,
On Fri, 18 Jul 2025 09:26:57 +0100 John Garry <john.g.garry@oracle•com> wrote:
>
> I think that this is the proper merge resolution:
>
> static void stripe_io_hints(struct dm_target *ti,
> struct queue_limits *limits)
> {
> struct stripe_c *sc = ti->private;
> unsigned int io_min, io_opt;
>
> if (!check_shl_overflow(sc->chunk_size, SECTOR_SHIFT, &io_min) && !check_mul_overflow(io_min, sc->stripes, &io_opt)) {
> limits->io_min = io_min;
> limits->io_opt = io_opt;
> }
> limits->chunk_sectors = sc->chunk_size;
> }
>
>
> For purpose of atomic writes, we should always set chunk_sectors.
OK, I have changed my resolution to that starting from Monday.
> BTW, I tried to apply the conflicting patches from the block tree on -next from 17 July, and I was getting strange behaviour:
>
> # vgcreate vg00 /dev/sda /dev/sdb /dev/sdc /dev/sdd
> WARNING: Unknown logical_block_size for device /dev/sda.
> WARNING: Unknown logical_block_size for device /dev/sdb.
> WARNING: Unknown logical_block_size for device /dev/sdc.
> WARNING: Unknown logical_block_size for device /dev/sdd.
> Physical volume "/dev/sda" successfully created.
> Physical volume "/dev/sdb" successfully created.
> Physical volume "/dev/sdc" successfully created.
> Physical volume "/dev/sdd" successfully created.
> Volume group "vg00" successfully created
> #
>
> I had no such problem on Jens' block for-6.17 tree.
I have no idea what caused that, sorry.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2025-07-18 8:56 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-18 5:10 linux-next: manual merge of the device-mapper tree with the block tree Stephen Rothwell
2025-07-18 8:26 ` John Garry
2025-07-18 8:56 ` Stephen Rothwell [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-07-28 3:14 Stephen Rothwell
2022-07-28 3:23 ` Ming Lei
2022-03-30 22:44 Stephen Rothwell
2022-04-01 5:20 ` Christoph Hellwig
2022-04-01 16:28 ` Mike Snitzer
2021-08-10 1:55 Stephen Rothwell
2020-07-09 3:21 Stephen Rothwell
2020-05-22 5:17 Stephen Rothwell
2018-12-10 3:43 Stephen Rothwell
2018-12-10 3:55 ` Jens Axboe
2018-12-10 5:13 ` Mike Snitzer
2016-07-21 3:27 Stephen Rothwell
2016-07-18 4:09 Stephen Rothwell
2016-06-09 3:59 Stephen Rothwell
2016-06-09 4:02 ` Stephen Rothwell
2016-06-10 17:01 ` Mike Snitzer
2015-09-02 2:39 Stephen Rothwell
2013-12-17 2:16 Stephen Rothwell
2010-07-06 4:33 Stephen Rothwell
2010-07-06 14:30 ` Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250718185642.0f2454c3@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=agk@redhat$(echo .)com \
--cc=axboe@kernel$(echo .)dk \
--cc=john.g.garry@oracle$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mpatocka@redhat$(echo .)com \
--cc=snitzer@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox