Subject: Re: linux-next: build failure after merge of the vfs-brauner tree

From: Stephen Rothwell <[email-masked]>
Date: Thu, 21 Aug 2025 08:54:41 +1000

Hi Christian,

On Wed, 20 Aug 2025 09:42:39 +1000 Stephen Rothwell <[email-masked]> wrote:
>
> On Mon, 18 Aug 2025 09:05:59 +1000 Stephen Rothwell <[email-masked]> wrote:
> >
> > After merging the vfs-brauner tree, today's linux-next build (powerpc
> > ppc64_defconfig) failed like this:
> > 
> > fs/iomap/direct-io.c: In function 'iomap_dio_zero':
> > fs/iomap/direct-io.c:281:36: error: implicit declaration of function 'largest_zero_folio'; did you mean 'is_zero_folio'? [-Wimplicit-function-declaration]
> >   281 |         struct folio *zero_folio = largest_zero_folio();
> >       |                                    ^~~~~~~~~~~~~~~~~~
> >       |                                    is_zero_folio
> > 
> > Caused by commit
> > 
> >   5589673e8d8d ("iomap: use largest_zero_folio() in iomap_dio_zero()")
> > 
> > I have used the vfs-brauner tree from next-20250815 for today.  
> 
> I am still getting this failure.

The above commit is still in your tree which makes it unbuildable since
the interface it uses does not exist in your tree (are you testing it?).

$ git grep -w largest_zero_folio vfs-brauner/vfs.all
vfs-brauner/vfs.all:fs/iomap/direct-io.c:       struct folio *zero_folio = largest_zero_folio();

$ git grep -w largest_zero_folio mm-unstable/mm-unstable 
mm-unstable/mm-unstable:block/blk-lib.c:        struct folio *zero_folio = largest_zero_folio();
mm-unstable/mm-unstable:include/linux/huge_mm.h: * largest_zero_folio - Get the largest zero size folio available
mm-unstable/mm-unstable:include/linux/huge_mm.h:static inline struct folio *largest_zero_folio(void)

Please fix this up - maybe just drop/revert that commit until it is
sorted out.
-- 
Cheers,
Stephen Rothwell