From: Nathan Chancellor <nathan@kernel•org>
To: Inochi Amaoto <inochiama@gmail•com>
Cc: Anders Roxell <anders.roxell@linaro•org>,
regressions@lists•linux.dev, linux-next@vger•kernel.org,
Thomas Gleixner <tglx@linutronix•de>,
Bjorn Helgaas <bhelgaas@google•com>,
Marc Zyngier <maz@kernel•org>,
Lorenzo Pieralisi <lpieralisi@kernel•org>,
Shradha Gupta <shradhagupta@linux•microsoft.com>,
Haiyang Zhang <haiyangz@microsoft•com>,
Jonathan Cameron <Jonathan.Cameron@huwei•com>,
Juergen Gross <jgross@suse•com>,
Nicolin Chen <nicolinc@nvidia•com>,
Jason Gunthorpe <jgg@ziepe•ca>,
Chen Wang <unicorn_wang@outlook•com>,
linux-kernel@vger•kernel.org, linux-pci@vger•kernel.org,
Yixun Lan <dlan@gentoo•org>, Longbin Li <looong.bin@gmail•com>,
arnd@arndb•de, dan.carpenter@linaro•org,
naresh.kamboju@linaro•org, benjamin.copeland@linaro•org
Subject: Re: [PATCH v2 2/4] PCI/MSI: Add startup/shutdown for per device domains
Date: Tue, 26 Aug 2025 17:47:19 -0700 [thread overview]
Message-ID: <20250827004719.GA2519033@ax162> (raw)
In-Reply-To: <qe23hkpdr6ui4mgjke2wp2pl3jmgcauzgrdxqq4olgrkbfy25d@avy6c6mg334s>
On Wed, Aug 27, 2025 at 07:28:46AM +0800, Inochi Amaoto wrote:
> OK, I guess I know why: I have missed one condition for startup.
>
> Could you test the following patch? If worked, I will send it as
> a fix.
Yes, that appears to resolve the issue on one system. I cannot test the
other at the moment since it is under load.
Tested-by: Nathan Chancellor <nathan@kernel•org>
> ---
> diff --git a/drivers/pci/msi/irqdomain.c b/drivers/pci/msi/irqdomain.c
> index e0a800f918e8..b11b7f63f0d6 100644
> --- a/drivers/pci/msi/irqdomain.c
> +++ b/drivers/pci/msi/irqdomain.c
> @@ -154,6 +154,8 @@ static void cond_shutdown_parent(struct irq_data *data)
>
> if (unlikely(info->flags & MSI_FLAG_PCI_MSI_STARTUP_PARENT))
> irq_chip_shutdown_parent(data);
> + else if (unlikely(info->flags & MSI_FLAG_PCI_MSI_MASK_PARENT))
> + irq_chip_mask_parent(data);
> }
>
> static unsigned int cond_startup_parent(struct irq_data *data)
> @@ -162,6 +164,9 @@ static unsigned int cond_startup_parent(struct irq_data *data)
>
> if (unlikely(info->flags & MSI_FLAG_PCI_MSI_STARTUP_PARENT))
> return irq_chip_startup_parent(data);
> + else if (unlikely(info->flags & MSI_FLAG_PCI_MSI_MASK_PARENT))
> + irq_chip_unmask_parent(data);
> +
> return 0;
> }
>
next prev parent reply other threads:[~2025-08-27 0:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250813232835.43458-1-inochiama@gmail.com>
[not found] ` <20250813232835.43458-3-inochiama@gmail.com>
2025-08-26 19:45 ` [PATCH v2 2/4] PCI/MSI: Add startup/shutdown for per device domains Anders Roxell
2025-08-26 22:09 ` Nathan Chancellor
2025-08-27 10:33 ` Mark Brown
2025-08-26 22:33 ` Inochi Amaoto
2025-08-26 23:28 ` Inochi Amaoto
2025-08-27 0:47 ` Nathan Chancellor [this message]
2025-08-27 8:17 ` Naresh Kamboju
2025-08-27 9:45 ` Inochi Amaoto
2025-08-27 9:44 ` Inochi Amaoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250827004719.GA2519033@ax162 \
--to=nathan@kernel$(echo .)org \
--cc=Jonathan.Cameron@huwei$(echo .)com \
--cc=anders.roxell@linaro$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=benjamin.copeland@linaro$(echo .)org \
--cc=bhelgaas@google$(echo .)com \
--cc=dan.carpenter@linaro$(echo .)org \
--cc=dlan@gentoo$(echo .)org \
--cc=haiyangz@microsoft$(echo .)com \
--cc=inochiama@gmail$(echo .)com \
--cc=jgg@ziepe$(echo .)ca \
--cc=jgross@suse$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=looong.bin@gmail$(echo .)com \
--cc=lpieralisi@kernel$(echo .)org \
--cc=maz@kernel$(echo .)org \
--cc=naresh.kamboju@linaro$(echo .)org \
--cc=nicolinc@nvidia$(echo .)com \
--cc=regressions@lists$(echo .)linux.dev \
--cc=shradhagupta@linux$(echo .)microsoft.com \
--cc=tglx@linutronix$(echo .)de \
--cc=unicorn_wang@outlook$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox