From: Andrew Morton <akpm@linux-foundation•org>
To: Ankur Arora <ankur.a.arora@oracle•com>
Cc: linux-kernel@vger•kernel.org, linux-arch@vger•kernel.org,
linux-arm-kernel@lists•infradead.org, linux-pm@vger•kernel.org,
linux-next@vger•kernel.org, bpf@vger•kernel.org, arnd@arndb•de,
catalin.marinas@arm•com, will@kernel•org, peterz@infradead•org,
mark.rutland@arm•com, harisokn@amazon•com, cl@gentwo•org,
ast@kernel•org, rafael@kernel•org, daniel.lezcano@linaro•org,
memxor@gmail•com, zhenglifeng1@huawei•com,
xueshuai@linux•alibaba.com, rdunlap@infradead•org,
david.laight.linux@gmail•com, joao.m.martins@oracle•com,
boris.ostrovsky@oracle•com, konrad.wilk@oracle•com,
ashok.bhat@arm•com, Boqun Feng <boqun.feng@gmail•com>,
Boqun Feng <boqun@kernel•org>, Christoph Lameter <cl@linux•com>,
Ingo Molnar <mingo@kernel•org>,
Konrad Dybcio <konradybcio@kernel•org>,
Mark Brown <broonie@kernel•org>
Subject: Re: [PATCH v11 1/2] kunit: add tests for smp_cond_load_*_timeout()
Date: Thu, 21 May 2026 14:46:29 -0700 [thread overview]
Message-ID: <20260521144629.11ee1e2ff88c5387a589f54a@linux-foundation.org> (raw)
In-Reply-To: <20260521083038.134260-1-ankur.a.arora@oracle.com>
On Thu, 21 May 2026 01:30:37 -0700 Ankur Arora <ankur.a.arora@oracle•com> wrote:
> Add success and failure case tests for smp_cond_load_*_timeout().
>
> All of the test cases wait on some state in smp_cond_load_*_timeout().
> In the success case we spawn a kthread that pokes the bit.
>
> Success or failure cases depend on the expected bit being set (or not).
> Additionally in failure cases smp_cond_load_*_timeout() cannot return
> before timeout.
Your title "kunit: ..." implies that this is a kunit patchset. ie, and
to my mind, this implies that the patchset makes changes to kunit
infrastructure. This isn't the case, of course.
>
> ...
>
> +config BARRIER_TIMEOUT_TEST
> + tristate "KUnit tests for smp_cond_load_relaxed_timeout()"
The patchset which attempted to add smp_cond_load_relaxed_timeout() was
titled "barrier: ...", which is a more appropriate identifier for this
patchset.
Anyway, I removed the series "barrier: Add
smp_cond_load_{relaxed,acquire}_timeout()" from mm.git on May 19 for
forgotten reasons. So I suggest that the series be respun and resent,
with these two test patches included.
Again, I'm really not the guy to be handling these patches. But a 4-6%
performance improvement in real world workloads is not to be ignored.
Not by me, anyway.
next prev parent reply other threads:[~2026-05-21 21:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260408122538.3610871-15-ankur.a.arora@oracle.com>
2026-05-21 8:30 ` [PATCH v11 1/2] kunit: add tests for smp_cond_load_*_timeout() Ankur Arora
2026-05-21 8:30 ` [PATCH v11 2/2] kunit: add clock tests for smp_cond_load_relaxed_timeout() Ankur Arora
2026-05-21 21:46 ` Andrew Morton [this message]
2026-05-21 21:57 ` [PATCH v11 1/2] kunit: add tests for smp_cond_load_*_timeout() Mark Brown
2026-05-22 5:10 ` Ankur Arora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260521144629.11ee1e2ff88c5387a589f54a@linux-foundation.org \
--to=akpm@linux-foundation$(echo .)org \
--cc=ankur.a.arora@oracle$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=ashok.bhat@arm$(echo .)com \
--cc=ast@kernel$(echo .)org \
--cc=boqun.feng@gmail$(echo .)com \
--cc=boqun@kernel$(echo .)org \
--cc=boris.ostrovsky@oracle$(echo .)com \
--cc=bpf@vger$(echo .)kernel.org \
--cc=broonie@kernel$(echo .)org \
--cc=catalin.marinas@arm$(echo .)com \
--cc=cl@gentwo$(echo .)org \
--cc=cl@linux$(echo .)com \
--cc=daniel.lezcano@linaro$(echo .)org \
--cc=david.laight.linux@gmail$(echo .)com \
--cc=harisokn@amazon$(echo .)com \
--cc=joao.m.martins@oracle$(echo .)com \
--cc=konrad.wilk@oracle$(echo .)com \
--cc=konradybcio@kernel$(echo .)org \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-pm@vger$(echo .)kernel.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=memxor@gmail$(echo .)com \
--cc=mingo@kernel$(echo .)org \
--cc=peterz@infradead$(echo .)org \
--cc=rafael@kernel$(echo .)org \
--cc=rdunlap@infradead$(echo .)org \
--cc=will@kernel$(echo .)org \
--cc=xueshuai@linux$(echo .)alibaba.com \
--cc=zhenglifeng1@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox