From: "Rafael J. Wysocki" <rjw@rjwysocki•net>
To: Dmitry Torokhov <dmitry.torokhov@gmail•com>,
Daniel Drake <drake@endlessm•com>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel•com>,
linux-next <linux-next@vger•kernel.org>,
lkml <linux-kernel@vger•kernel.org>
Subject: Re: linux-next: build failure after merge of the input-current tree
Date: Thu, 20 Sep 2018 10:02:24 +0200 [thread overview]
Message-ID: <2643253.QO5Q8yoTPK@aspire.rjw.lan> (raw)
In-Reply-To: <CAKdAkRR8NH8FxfRVsB2DCiyh7QVZLisqZgd1ZgHCnGpUO6KP-g@mail.gmail.com>
On Wednesday, September 19, 2018 12:32:03 AM CEST Dmitry Torokhov wrote:
> On Tue, Sep 18, 2018 at 3:25 PM Stephen Rothwell <sfr@canb•auug.org.au> wrote:
> >
> > Hi Dmitry,
> >
> > After merging the input-current tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > ERROR: "mem_sleep_current" [drivers/input/serio/i8042.ko] undefined!
> >
> > Caused by commit
> >
> > 1685830e59d4 ("Input: i8042 - enable keyboard wakeups by default when s2idle is used")
> >
> > I have used the version of input-current from next-20180918 for today.
>
> Ugh, sorry, I dropped that patch from my tree for now.
>
> Daniel, Rafael, I guess we can't make pm_suspend_via_s2idle() static
> inline, but instead move it into kernel/power/suspend.c and make it
> EXPORT_SYMBOL().
Either that, or mem_sleep_current would need to be exported. Sorry for
missing that.
Daniel, I prefer the wrapper to be a regular function in suspend.c.
Thanks,
Rafael
next prev parent reply other threads:[~2018-09-20 8:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-18 22:25 linux-next: build failure after merge of the input-current tree Stephen Rothwell
2018-09-18 22:32 ` Dmitry Torokhov
2018-09-20 8:02 ` Rafael J. Wysocki [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-05-23 22:24 Stephen Rothwell
2019-05-23 22:52 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2643253.QO5Q8yoTPK@aspire.rjw.lan \
--to=rjw@rjwysocki$(echo .)net \
--cc=dmitry.torokhov@gmail$(echo .)com \
--cc=drake@endlessm$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=rafael.j.wysocki@intel$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox