Subject: Re: linux-next: manual merge of the creds tree

From: David Howells <[email-masked]>
Date: Fri, 07 Nov 2008 15:04:48 +0000

Stephen Rothwell <[email-masked]> wrote:

>  +	read_lock_irq(&tasklist_lock);
>  +	psig = current->parent->sighand;
>  +	spin_lock_irqsave(&psig->siglock, flags);

There's no point using spin_lock_irqsave(): you've already disabled interrupts
with read_lock_irq().  Similarly:

>  +	spin_unlock_irqrestore(&psig->siglock, flags);
>  +	read_unlock_irq(&tasklist_lock);

spin_unlock_irqrestore() here is never going to re-enable interrupts.

Apart from that, it looks okay.

My tree and James's tree definitely need to meet before you see them.

David