Subject: Re: [linux-next]Build Failure: kernel/watchdog.c:936:2: error: too many arguments

From: Venkat Rao Bagalkote <[email-masked]>
Date: Mon, 28 Apr 2025 15:11:06 +0530

On 28/04/25 4:11 am, Stephen Rothwell wrote:
> Hi all,
>
> On Sat, 26 Apr 2025 20:39:26 +0530 Venkat Rao Bagalkote <[email-masked]> wrote:
>> I am observing below build failure on IBM Power8 server with linux-next-20250424 repo.
>>
>> This issue seems to be introduced by the below commit. After reverting the below commit, kernel build is successful.
>>
>> Bad Commit: 6b07f9a0fa41 watchdog: fix watchdog may detect false positive of softlockup
>>
>> Note: To hit this issue, one should first resolve this [1] <https://lore.kernel.org/all/[email-masked]/>
>>
>> Repo: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
>> Branch: master
>> GCC: 8.5.0 20210514
>> ldd (GNU libc) 2.28
>>
>> Attached is the .config file.
>>
>> Errors:
>>
>> kernel/watchdog.c: In function 'lockup_detector_reconfigure':
>> kernel/watchdog.c:936:2: error: too many arguments to function '__lockup_detector_reconfigure'
>>     __lockup_detector_reconfigure(false);
>>     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> kernel/watchdog.c:926:13: note: declared here
>>    static void __lockup_detector_reconfigure(void)
>>                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> kernel/watchdog.c: In function 'lockup_detector_setup':
>> kernel/watchdog.c:940:2: error: too many arguments to function '__lockup_detector_reconfigure'
>>     __lockup_detector_reconfigure(false);
>>     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> kernel/watchdog.c:926:13: note: declared here
>>    static void __lockup_detector_reconfigure(void)
>>                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> kernel/watchdog.c: In function 'proc_watchdog_update':
>> kernel/watchdog.c:962:2: error: too many arguments to function '__lockup_detector_reconfigure'
>>     __lockup_detector_reconfigure(thresh_changed);
>>     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> kernel/watchdog.c:926:13: note: declared here
>>    static void __lockup_detector_reconfigure(void)
>>                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>
>> If you happen to fix this, please add below tag.
>>
>> Reported-by: Venkat Rao Bagalkote <[email-masked]>
> Yeah, the CONFIG_SOFTLOCKUP_DETECTOR unset version of
> __lockup_detector_reconfigure() was not updated :-(

After seeting CONFIG_SOFTLOCKUP_DETECTOR kernel build is successful.

Regards,

Venkat.

>
> This is now commit
>
>    45c4eb661074 ("watchdog: fix watchdog may detect false positive of softlockup")
>
> in the mm-nonmm-unstable tree.
>