From: "Rafael J. Wysocki" <rjw@rjwysocki•net>
To: Sinan Kaya <okaya@kernel•org>, Darren Hart <dvhart@infradead•org>,
Andy Shevchenko <andy@infradead•org>
Cc: linux-next@vger•kernel.org, linux-acpi@vger•kernel.org,
"open list:X86 PLATFORM DRIVERS"
<platform-driver-x86@vger•kernel.org>,
open list <linux-kernel@vger•kernel.org>
Subject: Re: [for next][PATCH 1/2] platform/x86: Fix unmet dependency warning for ACPI_CMPC
Date: Thu, 24 Jan 2019 11:52:57 +0100 [thread overview]
Message-ID: <3681650.SPxszaOeRQ@aspire.rjw.lan> (raw)
In-Reply-To: <20190121224644.26903-1-okaya@kernel.org>
On Monday, January 21, 2019 11:46:43 PM CET Sinan Kaya wrote:
> Add BACKLIGHT_LCD_SUPPORT for ACPI_CMPC to fix the
> warning: unmet direct dependencies detected for BACKLIGHT_CLASS_DEVICE.
>
> ACPI_CMPC selects BACKLIGHT_LCD_SUPPORT but BACKLIGHT_LCD_SUPPORT
> depends on BACKLIGHT_LCD_SUPPORT.
>
> Copy this dependency into ACPI_CMPC.
>
> Signed-off-by: Sinan Kaya <okaya@kernel•org>
> ---
> drivers/platform/x86/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 5e2109c54c7c..b84c2c5b6684 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -904,7 +904,7 @@ config TOSHIBA_WMI
>
> config ACPI_CMPC
> tristate "CMPC Laptop Extras"
> - depends on ACPI && INPUT
> + depends on ACPI && INPUT && BACKLIGHT_LCD_SUPPORT
> depends on RFKILL || RFKILL=n
> select BACKLIGHT_CLASS_DEVICE
> help
>
Andy/Darren, these two seem to be for you, but I can take them too as
related to ACPI tagentially, so please let me know.
next prev parent reply other threads:[~2019-01-24 10:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 22:46 [for next][PATCH 1/2] platform/x86: Fix unmet dependency warning for ACPI_CMPC Sinan Kaya
2019-01-21 22:46 ` [for next][PATCH 2/2] platform/x86: Fix unmet dependency warning for SAMSUNG_Q10 Sinan Kaya
2019-01-21 22:48 ` [for next][PATCH 1/2] platform/x86: Fix unmet dependency warning for ACPI_CMPC Sinan Kaya
2019-01-24 10:52 ` Rafael J. Wysocki [this message]
2019-01-24 17:44 ` Sinan Kaya
2019-01-24 19:16 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3681650.SPxszaOeRQ@aspire.rjw.lan \
--to=rjw@rjwysocki$(echo .)net \
--cc=andy@infradead$(echo .)org \
--cc=dvhart@infradead$(echo .)org \
--cc=linux-acpi@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=okaya@kernel$(echo .)org \
--cc=platform-driver-x86@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox