From: David Howells <dhowells@redhat•com>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: dhowells@redhat•com, James Morris <jmorris@namei•org>,
linux-next@vger•kernel.org
Subject: Re: linux-next: creds tree build failure
Date: Fri, 08 Aug 2008 08:34:39 +0100 [thread overview]
Message-ID: <3708.1218180879@redhat.com> (raw)
In-Reply-To: <20080808163633.d9e10b46.sfr@canb.auug.org.au>
Stephen Rothwell <sfr@canb•auug.org.au> wrote:
> +++ b/arch/powerpc/platforms/cell/spufs/inode.c
> ...
> +#include <linux/cred.h>
Yep.
> - filp = dentry_open(dentry, mnt, O_RDONLY);
> + filp = dentry_open(dentry, mnt, O_RDONLY, current_cred());
Yep.
> - filp = dentry_open(dentry, mnt, O_RDONLY);
> + filp = dentry_open(dentry, mnt, O_RDONLY, current_cred());
Yep.
> +#ifdef CONFIG_KEYS
> /*
> * Release a set of thread group credentials.
> */
> void put_tgcred(struct thread_group_cred *tgcred)
> {
> -#ifdef CONFIG_KEYS
> if (atomic_dec_and_test(&tgcred->usage))
> call_rcu(&tgcred->rcu, put_tgcred_rcu);
> -#endif
> }
> +#else
> +#define put_tgcred(t)
> +#endif
That'll do.
> int copy_creds(struct task_struct *p, unsigned long clone_flags)
> {
> +#ifdef CONFIG_KEYS
> struct thread_group_cred *tgcred;
> +#endif
> struct cred *new;
>
> mutex_init(&p->cred_exec_mutex);
>
> +#ifdef CONFIG_KEYS
> if (!p->cred->thread_keyring && clone_flags & CLONE_THREAD) {
> +#else
> + if (clone_flags & CLONE_THREAD) {
> +#endif
> p->real_cred = get_cred(p->cred);
> get_cred(p->cred);
> return 0;
That should be okay.
Seems I forgot to compile with CONFIG_KEYS=n.
David
next prev parent reply other threads:[~2008-08-08 7:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-08 6:36 linux-next: creds tree build failure Stephen Rothwell
2008-08-08 7:34 ` David Howells [this message]
2008-08-08 10:58 ` James Morris
-- strict thread matches above, loose matches on Subject: below --
2008-10-17 6:25 Stephen Rothwell
2008-10-17 7:36 ` James Morris
2008-10-17 7:56 ` Stephen Rothwell
2008-10-17 10:37 ` David Howells
2008-10-17 10:55 ` Stephen Rothwell
2008-10-17 11:26 ` Ian Kent
2008-10-17 11:34 ` David Howells
2008-10-17 11:38 ` Ian Kent
2008-10-17 16:17 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3708.1218180879@redhat.com \
--to=dhowells@redhat$(echo .)com \
--cc=jmorris@namei$(echo .)org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox