From: Hans de Goede <hdegoede@redhat•com>
To: Divya Bharathi <divya27392@gmail•com>, dvhart@infradead•org
Cc: LKML <linux-kernel@vger•kernel.org>,
Linux Next Mailing List <linux-next@vger•kernel.org>,
platform-driver-x86@vger•kernel.org,
Divya Bharathi <divya.bharathi@dell•com>,
Mario Limonciello <mario.limonciello@dell•com>,
Prasanth KSR <prasanth.ksr@dell•com>
Subject: Re: [PATCH] platform/x86: dell-wmi-sysman: work around for BIOS bug
Date: Mon, 7 Dec 2020 15:05:52 +0100 [thread overview]
Message-ID: <39f8a3a5-88ff-7e1d-8ce3-ebec8c01427e@redhat.com> (raw)
In-Reply-To: <20201202131935.307372-1-divya.bharathi@dell.com>
Hi,
On 12/2/20 2:19 PM, Divya Bharathi wrote:
> BIOS sets incorrect value (zero) when SET value passed for integer attribute
> with + sign. Added workaround to remove + sign before passing input to BIOS
>
> Co-developed-by: Mario Limonciello <mario.limonciello@dell•com>
> Signed-off-by: Mario Limonciello <mario.limonciello@dell•com>
> Co-developed-by: Prasanth KSR <prasanth.ksr@dell•com>
> Signed-off-by: Prasanth KSR <prasanth.ksr@dell•com>
> Signed-off-by: Divya Bharathi <divya.bharathi@dell•com>
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> drivers/platform/x86/dell-wmi-sysman/int-attributes.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/dell-wmi-sysman/int-attributes.c b/drivers/platform/x86/dell-wmi-sysman/int-attributes.c
> index ea773d8e8d3a..75aedbb733be 100644
> --- a/drivers/platform/x86/dell-wmi-sysman/int-attributes.c
> +++ b/drivers/platform/x86/dell-wmi-sysman/int-attributes.c
> @@ -39,7 +39,7 @@ static ssize_t current_value_show(struct kobject *kobj, struct kobj_attribute *a
> * @instance_id: The instance on which input is validated
> * @buf: Input value
> */
> -static int validate_integer_input(int instance_id, const char *buf)
> +static int validate_integer_input(int instance_id, char *buf)
> {
> int in_val;
> int ret;
> @@ -51,6 +51,12 @@ static int validate_integer_input(int instance_id, const char *buf)
> in_val > wmi_priv.integer_data[instance_id].max_value)
> return -EINVAL;
>
> + /* workaround for BIOS error.
> + * validate input to avoid setting 0 when integer input passed with + sign
> + */
> + if (*buf == '+')
> + memmove(buf, (buf + 1), strlen(buf + 1) + 1);
> +
> return ret;
> }
>
>
next prev parent reply other threads:[~2020-12-07 14:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 13:19 [PATCH] platform/x86: dell-wmi-sysman: work around for BIOS bug Divya Bharathi
2020-12-07 14:05 ` Hans de Goede [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-12-02 6:56 Divya Bharathi
2020-12-02 12:21 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39f8a3a5-88ff-7e1d-8ce3-ebec8c01427e@redhat.com \
--to=hdegoede@redhat$(echo .)com \
--cc=divya.bharathi@dell$(echo .)com \
--cc=divya27392@gmail$(echo .)com \
--cc=dvhart@infradead$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mario.limonciello@dell$(echo .)com \
--cc=platform-driver-x86@vger$(echo .)kernel.org \
--cc=prasanth.ksr@dell$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox